Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Unified Diff: content/browser/browser_plugin/browser_plugin_host.h

Issue 10412056: Browser Plugin: Remove MapInstance from BrowserPluginHost + More cross-process navigation work (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed commented out code Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_host.h
diff --git a/content/browser/browser_plugin/browser_plugin_host.h b/content/browser/browser_plugin/browser_plugin_host.h
index 2e7dc890f6365a243566c86d5227eb6f99d17464..935058e4a6e07ae34f521b709a3bfa5772794871 100644
--- a/content/browser/browser_plugin/browser_plugin_host.h
+++ b/content/browser/browser_plugin/browser_plugin_host.h
@@ -38,10 +38,6 @@ class BrowserPluginHost : public WebContentsObserver,
virtual ~BrowserPluginHost();
- // TODO(fsamuel): Remove this once BrowserPluginHost_MapInstance
- // is removed.
- void OnPendingNavigation(RenderViewHost* dest_rvh);
-
void ConnectEmbedderToChannel(RenderViewHost* render_view_host,
const IPC::ChannelHandle& handle);
@@ -57,6 +53,7 @@ class BrowserPluginHost : public WebContentsObserver,
RenderProcessHost* embedder_render_process_host() const {
return embedder_render_process_host_;
}
+ int instance_id() const { return instance_id_; }
private:
typedef std::map<WebContentsImpl*, int64> GuestMap;
@@ -86,30 +83,15 @@ class BrowserPluginHost : public WebContentsObserver,
RenderProcessHost* embedder_render_process_host) {
embedder_render_process_host_ = embedder_render_process_host;
}
- int instance_id() const { return instance_id_; }
void set_instance_id(int instance_id) { instance_id_ = instance_id; }
const gfx::Size& initial_size() const { return initial_size_; }
void set_initial_size(const gfx::Size& size) { initial_size_ = size; }
- RenderViewHost* pending_render_view_host() const {
- return pending_render_view_host_;
- }
void OnNavigateFromGuest(PP_Instance instance,
const std::string& src);
void DestroyGuests();
- // TODO(fsamuel): Replace BrowserPluginHost_MapInstance with a message
- // over the GuestToEmbedderChannel that tells the guest to size itself
- // and begin compositing. Currently we use the guest's routing ID to look
- // up the appropriate guest in
- // BrowserPluginChannelManager::OnCompleteNavigation. In order to bypass the
- // need to grab a routing ID from the browser process, we can instead pass the
- // container instance ID to the guest on ViewMsg_New. The container instance
- // ID and the embedder channel name can then be used together to uniquely
- // identify a guest RenderViewImpl within a render process.
- void OnMapInstance(int container_instance_id, PP_Instance instance);
-
// WebContentObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
// Used to monitor frame navigation to cleanup guests when a frame navigates
@@ -138,12 +120,6 @@ class BrowserPluginHost : public WebContentsObserver,
gfx::Size initial_size_;
GuestMap guests_;
ContainerInstanceMap guests_by_container_id_;
- // TODO(fsamuel): This should not be exposed outside of WebContentsImpl
- // because this can change at any time. Remove this, along with
- // OnPendingNavigation once BrowserPluginHost_MapInstance is modified
- // to be sent over the GuestToEmbedderChannel directly instead of through
- // the browser process.
- RenderViewHost* pending_render_view_host_;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698