Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 10412056: Browser Plugin: Remove MapInstance from BrowserPluginHost + More cross-process navigation work (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simplified size logic Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 76a23531dc7e720c7f6a656d54c8f1648a42c7e0..70edf3299cb49d46c2338c954b55a08ccba7555c 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -205,10 +205,12 @@ content::SiteInstance* RenderViewHostImpl::GetSiteInstance() const {
return instance_;
}
-bool RenderViewHostImpl::CreateRenderView(const string16& frame_name,
- int opener_route_id,
- int32 max_page_id,
- int embedder_process_id) {
+bool RenderViewHostImpl::CreateRenderView(
+ const string16& frame_name,
+ int opener_route_id,
+ int32 max_page_id,
+ const std::string& embedder_channel_name,
+ int embedder_container_id) {
DCHECK(!IsRenderViewLive()) << "Creating view twice";
// The process may (if we're sharing a process with another host that already
@@ -257,12 +259,8 @@ bool RenderViewHostImpl::CreateRenderView(const string16& frame_name,
WebKit::WebScreenInfoFactory::screenInfo(
gfx::NativeViewFromId(GetNativeViewId()));
#endif
-
- if (embedder_process_id != -1) {
- params.embedder_channel_name =
- StringPrintf("%d.r%d", GetProcess()->GetID(), embedder_process_id);
- }
-
+ params.embedder_channel_name = embedder_channel_name;
+ params.embedder_container_id = embedder_container_id;
params.accessibility_mode =
BrowserAccessibilityState::GetInstance()->IsAccessibleBrowser() ?
AccessibilityModeComplete :

Powered by Google App Engine
This is Rietveld 408576698