Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 10412053: Whitelist unreachable webdata pages for content settings (Closed)

Created:
8 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 7 months ago
Reviewers:
Jói, marja
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Whitelist unreachable webdata pages for content settings BUG=125488 TEST=disable JS, go to https://no.such.host/. Should show a regular error page NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138464

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/renderer/content_settings_observer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/url_constants.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jochen (gone - plz use gerrit)
plz review
8 years, 7 months ago (2012-05-23 08:42:15 UTC) #1
marja
lgtm
8 years, 7 months ago (2012-05-23 08:43:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10412053/1
8 years, 7 months ago (2012-05-23 08:44:49 UTC) #3
commit-bot: I haz the power
Try job failure for 10412053-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-23 09:04:56 UTC) #4
Jói
LGTM for content/public
8 years, 7 months ago (2012-05-23 10:00:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10412053/10001
8 years, 7 months ago (2012-05-23 10:27:06 UTC) #6
commit-bot: I haz the power
Try job failure for 10412053-10001 (retry) on win_rel for step "runhooks". It's a second try, ...
8 years, 7 months ago (2012-05-23 13:11:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10412053/10001
8 years, 7 months ago (2012-05-23 13:12:43 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 13:13:27 UTC) #9
Change committed as 138464

Powered by Google App Engine
This is Rietveld 408576698