Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: vm/intermediate_language_ia32.cc

Issue 10412043: Make it less verbose to declare instructions that use LocationSummary-based code generation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/intermediate_language.h ('k') | vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/intermediate_language_ia32.cc
===================================================================
--- vm/intermediate_language_ia32.cc (revision 7878)
+++ vm/intermediate_language_ia32.cc (working copy)
@@ -13,61 +13,23 @@
namespace dart {
-#define DEFINE_UNIMPLEMENTED(name) \
- LocationSummary* name::MakeLocationSummary() { \
- UNIMPLEMENTED(); \
- return NULL; \
- } \
- \
- void name::EmitNativeCode(FlowGraphCompiler* compiler) { \
- UNIMPLEMENTED(); \
+#define DEFINE_UNIMPLEMENTED(ShortName, ClassName) \
+ LocationSummary* ClassName::MakeLocationSummary() const { \
+ UNIMPLEMENTED(); \
+ return NULL; \
+ } \
+ \
+ void ClassName::EmitNativeCode(FlowGraphCompiler* compiler) { \
+ UNIMPLEMENTED(); \
}
-DEFINE_UNIMPLEMENTED(StrictCompareComp)
-DEFINE_UNIMPLEMENTED(ClosureCallComp)
-DEFINE_UNIMPLEMENTED(InstanceCallComp)
-DEFINE_UNIMPLEMENTED(StaticCallComp)
-DEFINE_UNIMPLEMENTED(CurrentContextComp)
-DEFINE_UNIMPLEMENTED(StoreContextComp)
+FOR_EACH_COMPUTATION(DEFINE_UNIMPLEMENTED)
void BindInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
UNIMPLEMENTED();
}
-LocationSummary* LoadLocalComp::MakeLocationSummary() {
- UNIMPLEMENTED();
- return NULL;
-}
-
-
-void LoadLocalComp::EmitNativeCode(FlowGraphCompiler* compiler) {
- UNIMPLEMENTED();
-}
-
-
-LocationSummary* StoreLocalComp::MakeLocationSummary() {
- UNIMPLEMENTED();
- return NULL;
-}
-
-
-void StoreLocalComp::EmitNativeCode(FlowGraphCompiler* compiler) {
- UNIMPLEMENTED();
-}
-
-
-LocationSummary* ConstantVal::MakeLocationSummary() {
- UNIMPLEMENTED();
- return NULL;
-}
-
-
-void ConstantVal::EmitNativeCode(FlowGraphCompiler* compiler) {
- UNIMPLEMENTED();
-}
-
-
} // namespace dart
#undef __
« no previous file with comments | « vm/intermediate_language.h ('k') | vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698