Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: vm/intermediate_language_ia32.cc

Issue 10412043: Make it less verbose to declare instructions that use LocationSummary-based code generation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/intermediate_language_ia32.cc
===================================================================
--- vm/intermediate_language_ia32.cc (revision 7878)
+++ vm/intermediate_language_ia32.cc (working copy)
@@ -14,7 +14,7 @@
#define DEFINE_UNIMPLEMENTED(name) \
- LocationSummary* name::MakeLocationSummary() { \
+ LocationSummary* name::MakeLocationSummary() const { \
UNIMPLEMENTED(); \
return NULL; \
} \
@@ -29,45 +29,16 @@
DEFINE_UNIMPLEMENTED(StaticCallComp)
DEFINE_UNIMPLEMENTED(CurrentContextComp)
DEFINE_UNIMPLEMENTED(StoreContextComp)
+DEFINE_UNIMPLEMENTED(LoadLocalComp)
+DEFINE_UNIMPLEMENTED(StoreLocalComp)
+DEFINE_UNIMPLEMENTED(ConstantVal)
+
void BindInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
UNIMPLEMENTED();
}
-LocationSummary* LoadLocalComp::MakeLocationSummary() {
- UNIMPLEMENTED();
- return NULL;
-}
-
-
-void LoadLocalComp::EmitNativeCode(FlowGraphCompiler* compiler) {
- UNIMPLEMENTED();
-}
-
-
-LocationSummary* StoreLocalComp::MakeLocationSummary() {
- UNIMPLEMENTED();
- return NULL;
-}
-
-
-void StoreLocalComp::EmitNativeCode(FlowGraphCompiler* compiler) {
- UNIMPLEMENTED();
-}
-
-
-LocationSummary* ConstantVal::MakeLocationSummary() {
- UNIMPLEMENTED();
- return NULL;
-}
-
-
-void ConstantVal::EmitNativeCode(FlowGraphCompiler* compiler) {
- UNIMPLEMENTED();
-}
-
-
} // namespace dart
#undef __

Powered by Google App Engine
This is Rietveld 408576698