Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: Source/WebCore/html/shadow/MediaControlRootElement.cpp

Issue 10412040: Merge 116900 - Volume slider needs to be displayed below the mute button (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/WebCore/html/shadow/MediaControlElements.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/html/shadow/MediaControlRootElement.cpp
===================================================================
--- Source/WebCore/html/shadow/MediaControlRootElement.cpp (revision 118042)
+++ Source/WebCore/html/shadow/MediaControlRootElement.cpp (working copy)
@@ -186,6 +186,15 @@
if (ec)
return 0;
+ // This is a duplicate mute button, which is visible in some ports at the bottom of the volume bar.
+ // It's important only when the volume bar is displayed below the controls.
+ RefPtr<MediaControlVolumeSliderMuteButtonElement> volumeSliderMuteButton = MediaControlVolumeSliderMuteButtonElement::create(document);
+ controls->m_volumeSliderMuteButton = volumeSliderMuteButton.get();
+ volumeSliderContainer->appendChild(volumeSliderMuteButton.release(), ec, true);
+
+ if (ec)
+ return 0;
+
controls->m_volumeSliderContainer = volumeSliderContainer.get();
panelVolumeControlContainer->appendChild(volumeSliderContainer.release(), ec, true);
if (ec)
« no previous file with comments | « Source/WebCore/html/shadow/MediaControlElements.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698