Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: Source/WebCore/html/shadow/MediaControlRootElement.cpp

Issue 10412040: Merge 116900 - Volume slider needs to be displayed below the mute button (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/html/shadow/MediaControlElements.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 179
180 if (document->page()->theme()->usesMediaControlVolumeSlider()) { 180 if (document->page()->theme()->usesMediaControlVolumeSlider()) {
181 RefPtr<MediaControlVolumeSliderContainerElement> volumeSliderContainer = MediaControlVolumeSliderContainerElement::create(document); 181 RefPtr<MediaControlVolumeSliderContainerElement> volumeSliderContainer = MediaControlVolumeSliderContainerElement::create(document);
182 182
183 RefPtr<MediaControlVolumeSliderElement> slider = MediaControlVolumeSlide rElement::create(document); 183 RefPtr<MediaControlVolumeSliderElement> slider = MediaControlVolumeSlide rElement::create(document);
184 controls->m_volumeSlider = slider.get(); 184 controls->m_volumeSlider = slider.get();
185 volumeSliderContainer->appendChild(slider.release(), ec, true); 185 volumeSliderContainer->appendChild(slider.release(), ec, true);
186 if (ec) 186 if (ec)
187 return 0; 187 return 0;
188 188
189 // This is a duplicate mute button, which is visible in some ports at th e bottom of the volume bar.
190 // It's important only when the volume bar is displayed below the contro ls.
191 RefPtr<MediaControlVolumeSliderMuteButtonElement> volumeSliderMuteButton = MediaControlVolumeSliderMuteButtonElement::create(document);
192 controls->m_volumeSliderMuteButton = volumeSliderMuteButton.get();
193 volumeSliderContainer->appendChild(volumeSliderMuteButton.release(), ec, true);
194
195 if (ec)
196 return 0;
197
189 controls->m_volumeSliderContainer = volumeSliderContainer.get(); 198 controls->m_volumeSliderContainer = volumeSliderContainer.get();
190 panelVolumeControlContainer->appendChild(volumeSliderContainer.release() , ec, true); 199 panelVolumeControlContainer->appendChild(volumeSliderContainer.release() , ec, true);
191 if (ec) 200 if (ec)
192 return 0; 201 return 0;
193 } 202 }
194 203
195 RefPtr<MediaControlPanelMuteButtonElement> panelMuteButton = MediaControlPan elMuteButtonElement::create(document, controls.get()); 204 RefPtr<MediaControlPanelMuteButtonElement> panelMuteButton = MediaControlPan elMuteButtonElement::create(document, controls.get());
196 controls->m_panelMuteButton = panelMuteButton.get(); 205 controls->m_panelMuteButton = panelMuteButton.get();
197 panelVolumeControlContainer->appendChild(panelMuteButton.release(), ec, true ); 206 panelVolumeControlContainer->appendChild(panelMuteButton.release(), ec, true );
198 if (ec) 207 if (ec)
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 { 659 {
651 // We only need to update buffering progress when paused, during normal 660 // We only need to update buffering progress when paused, during normal
652 // playback playbackProgressed() will take care of it. 661 // playback playbackProgressed() will take care of it.
653 if (m_mediaController->paused()) 662 if (m_mediaController->paused())
654 m_timeline->setPosition(m_mediaController->currentTime()); 663 m_timeline->setPosition(m_mediaController->currentTime());
655 } 664 }
656 665
657 } 666 }
658 667
659 #endif 668 #endif
OLDNEW
« no previous file with comments | « Source/WebCore/html/shadow/MediaControlElements.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698