Roll libphonenumber r456

Roll libphonenumber r456

This also changes libphonenumber.gyp. A separate library with no metadata needs
to be built. This allows us to build a production library with production
metadata and the unit tests with testing metadata. Before that it was unclear
which metadata was used for testing.

TEST=libphonenumber_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139410

[Leandro Graciá Gil, 2012-05-25 10:16:17]

LGTM.

[Philippe, 2012-05-25 10:20:20]

On 2012/05/25 10:16:17, Leandro Graciá Gil wrote:
> LGTM.

Hi Leandro,

Do you know who I can add for approval (if required)? George Yakovlev who
approved your previous roll of libphonenumber left Google.

Cheers,
Philippe.

[Leandro Graciá Gil, 2012-05-25 10:23:55]

On 2012/05/25 10:20:20, Philippe wrote:
> On 2012/05/25 10:16:17, Leandro Graciá Gil wrote:
> > LGTM.
> 
> Hi Leandro,
> 
> Do you know who I can add for approval (if required)? George Yakovlev who
> approved your previous roll of libphonenumber left Google.
> 
> Cheers,
> Philippe.

I'm afraid I don't know, sorry.

[Philippe, 2012-05-25 10:27:15]

On 2012/05/25 10:23:55, Leandro Graciá Gil wrote:
> On 2012/05/25 10:20:20, Philippe wrote:
> > On 2012/05/25 10:16:17, Leandro Graciá Gil wrote:
> > > LGTM.
> > 
> > Hi Leandro,
> > 
> > Do you know who I can add for approval (if required)? George Yakovlev who
> > approved your previous roll of libphonenumber left Google.
> > 
> > Cheers,
> > Philippe.
> 
> I'm afraid I don't know, sorry.

I'm adding isherman@. He's one of the autofill owners.

[Ilya Sherman, 2012-05-25 19:56:07]

LGTM, thanks

https://chromiumcodereview.appspot.com/10412031/diff/13001/third_party/libpho...
File third_party/libphonenumber/libphonenumber.gyp (right):

https://chromiumcodereview.appspot.com/10412031/diff/13001/third_party/libpho...
third_party/libphonenumber/libphonenumber.gyp:70: # Library used by clients that
includes production metadata.
nit: Please move this line immediately above the "target_name", to match the
placement of the comment on lines 28-29.

[Philippe, 2012-05-29 07:47:47]

https://chromiumcodereview.appspot.com/10412031/diff/13001/third_party/libpho...
File third_party/libphonenumber/libphonenumber.gyp (right):

https://chromiumcodereview.appspot.com/10412031/diff/13001/third_party/libpho...
third_party/libphonenumber/libphonenumber.gyp:70: # Library used by clients that
includes production metadata.
On 2012/05/25 19:56:08, Ilya Sherman wrote:
> nit: Please move this line immediately above the "target_name", to match the
> placement of the comment on lines 28-29.

Done.

[commit-bot: I haz the power, 2012-05-29 07:48:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10412031/20001

[commit-bot: I haz the power, 2012-05-29 07:48:29]

Failed to apply patch for third_party/libphonenumber/libphonenumber.gyp:
While running patch -p1 --forward --force;
patching file third_party/libphonenumber/libphonenumber.gyp
Hunk #4 FAILED at 54.
Hunk #5 succeeded at 74 (offset 1 line).
Hunk #6 succeeded at 114 (offset 1 line).
1 out of 6 hunks FAILED -- saving rejects to file
third_party/libphonenumber/libphonenumber.gyp.rej

[commit-bot: I haz the power, 2012-05-29 09:38:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10412031/21002

[commit-bot: I haz the power, 2012-05-29 10:06:55]

Try job failure for 10412031-21002 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[Philippe, 2012-05-29 15:17:11]

On 2012/05/29 10:06:55, I haz the power (commit-bot) wrote:
> Try job failure for 10412031-21002 (retry) on android for steps "compile,
build"
> (clobber build).
> It's a second try, previously, steps "compile, build" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

Hi Ilya,

I had some failures on the android build bot. I had to make some small changes
in libphonenumber.gyp.

Could you please take another quick look at this file before I submit?

Thanks in advance,
Philippe.

[Ilya Sherman, 2012-05-29 20:54:37]

LGTM

[commit-bot: I haz the power, 2012-05-29 20:55:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/10412031/14007

[commit-bot: I haz the power, 2012-05-29 23:00:16]

Change committed as 139410