Merging ContentArray into DescriptorArray

Merging ContentArray into DescriptorArray

Committed: https://code.google.com/p/v8/source/detail?r=11703

[Florian Schneider, 2012-05-22 16:53:09]

I like the change.

Some formatting drive-by comments:

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/mark-compact.cc...
src/mark-compact.cc:1898: mark_compact_collector()->RecordSlot(descriptor_start,
value_slot, *value_slot);
Long line.

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects-inl.h
File src/objects-inl.h (right):

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects-inl.h#n...
src/objects-inl.h:1938: Object** DescriptorArray::GetValueSlot(int
descriptor_number) {
Two empty lines between function definitions.

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects-inl.h#n...
src/objects-inl.h:1945: Object* DescriptorArray::GetValue(int descriptor_number)
{
Two empty lines between function definitions. Here and in the other places.

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.cc#newc...
src/objects.cc:4919:
static_cast<AccessorPair*>(descriptor_array_->GetValue(index / 2));
Long line.

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.cc#newc...
src/objects.cc:5054: Object* object = *HeapObject::RawField(this,
kInstanceDescriptorsOrBitField3Offset);
Long line.

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.cc#newc...
src/objects.cc:5082: IntrusiveMapTransitionIterator
descriptor_iterator(MutatedInstanceDescriptors());
Long line.

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.h#newco...
src/objects.h:2504: // stack-allocated right after creating a descriptor array.
By allocating a witness,
Long line.

https://chromiumcodereview.appspot.com/10412030/diff/4001/src/objects.h#newco...
src/objects.h:2612: static const int kDescriptorSize = 3;
Maybe sort the constants for the layout by increasing numbers.

[Michael Starzinger, 2012-06-01 14:03:15]

LGTM (just a nit). I like that change.

https://chromiumcodereview.appspot.com/10412030/diff/13002/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/10412030/diff/13002/src/mark-compact.c...
src/mark-compact.cc:1873: if (descriptors->HasEnumCache()) {
It's important that we don't forget to mark every object that could be
referenced from the header. So a comment about this block explaining that might
be a good idea.

https://chromiumcodereview.appspot.com/10412030/diff/13002/src/mark-compact.c...
src/mark-compact.cc:1900: *value_slot);
Just pass "value" as the third parameter here.

[Toon Verwaest, 2012-06-04 07:30:45]

https://chromiumcodereview.appspot.com/10412030/diff/13002/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/10412030/diff/13002/src/mark-compact.c...
src/mark-compact.cc:1873: if (descriptors->HasEnumCache()) {
On 2012/06/01 14:03:15, Michael Starzinger wrote:
> It's important that we don't forget to mark every object that could be
> referenced from the header. So a comment about this block explaining that
might
> be a good idea.

Done.

https://chromiumcodereview.appspot.com/10412030/diff/13002/src/mark-compact.c...
src/mark-compact.cc:1900: *value_slot);
On 2012/06/01 14:03:15, Michael Starzinger wrote:
> Just pass "value" as the third parameter here.

Done.