Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 10412028: Convert printing code to use base::TimeDelta in PostDelayedTask interfaces. (Closed)

Created:
8 years, 7 months ago by Ted Vessenes
Modified:
8 years, 7 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Convert printing code to use base::TimeDelta in PostDelayedTask interfaces. R=abodenha@chromium.org BUG=108171 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/printing/print_job.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Ted Vessenes
8 years, 7 months ago (2012-05-22 01:15:23 UTC) #1
Albert Bodenhamer
LGTM Please run a set of try jobs before committing or use the commit queue.
8 years, 7 months ago (2012-05-22 16:00:39 UTC) #2
Ted Vessenes
On 2012/05/22 16:00:39, Albert Bodenhamer wrote: > LGTM > > Please run a set of ...
8 years, 7 months ago (2012-05-22 16:43:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10412028/1
8 years, 7 months ago (2012-05-22 16:44:18 UTC) #4
commit-bot: I haz the power
Try job failure for 10412028-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 18:33:14 UTC) #5
Ted Vessenes
This is a compilation problem on the master branch. (Looking at logs, apparently some disk ...
8 years, 7 months ago (2012-05-22 18:37:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10412028/1
8 years, 7 months ago (2012-05-22 21:06:11 UTC) #7
commit-bot: I haz the power
Try job failure for 10412028-1 (retry) (retry) on win_rel for step "runhooks" (clobber build). It's ...
8 years, 7 months ago (2012-05-23 05:41:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/10412028/1
8 years, 7 months ago (2012-05-23 14:28:21 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 17:07:19 UTC) #10
Change committed as 138500

Powered by Google App Engine
This is Rietveld 408576698