Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: tests/html/window_open_test.dart

Issue 10412015: aChange all asyncTest/callbackDone style tests to use the new expectAsync/ (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #library('WindowOpenTest'); 1 #library('WindowOpenTest');
2 #import('../../lib/unittest/unittest.dart'); 2 #import('../../lib/unittest/unittest.dart');
3 #import('../../lib/unittest/html_config.dart'); 3 #import('../../lib/unittest/html_config.dart');
4 #import('dart:html'); 4 #import('dart:html');
5 5
6 main() { 6 main() {
7 evaluateJavaScript(code) { 7 evaluateJavaScript(code) {
8 final scriptTag = new Element.tag('script'); 8 final scriptTag = new Element.tag('script');
9 scriptTag.innerHTML = code; 9 scriptTag.innerHTML = code;
10 document.body.nodes.add(scriptTag); 10 document.body.nodes.add(scriptTag);
11 } 11 }
12 evaluateJavaScript('layoutTestController.setCanOpenWindows()'); 12 evaluateJavaScript('layoutTestController.setCanOpenWindows()');
13 13
14 useHtmlConfiguration(); 14 useHtmlConfiguration();
15 asyncTest('TwoArgumentVersion', 1, () { 15 test('TwoArgumentVersion', () {
16 Window win = window.open('../resources/pong.html', 'testWindow'); 16 Window win = window.open('../resources/pong.html', 'testWindow');
17 closeWindow(win); 17 closeWindow(win);
18 }); 18 });
19 asyncTest('ThreeArgumentVersion', 1, () { 19 test('ThreeArgumentVersion', () {
20 Window win = window.open("resources/pong.html", "testWindow", "scrollbars=ye s,width=75,height=100"); 20 Window win = window.open("resources/pong.html", "testWindow", "scrollbars=ye s,width=75,height=100");
21 closeWindow(win); 21 closeWindow(win);
22 }); 22 });
23 } 23 }
24 24
25 closeWindow(win) { 25 closeWindow(win) {
26 win.close(); 26 win.close();
27 doneHandler() { 27 doneHandler() {
28 window.setTimeout(win.closed ? callbackDone : doneHandler, 1); 28 if (!win.closed) {
29 window.setTimeout(expectAsync0(doneHandler), 1);
30 }
29 } 31 }
30 window.setTimeout(doneHandler, 1); 32 window.setTimeout(expectAsync0(doneHandler), 1);
31 } 33 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698