Issue 10412014: Get PPB_Audio interface building as untrusted code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10412014: Get PPB_Audio interface building as untrusted code. (Closed)

Created:
8 years, 7 months ago by bbudge

Modified:
8 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get PPB_Audio interface building as untrusted code. Add audio source files needed for PPB_Audio to build, and #ifdef out host side code. Flesh out the SyncSocket and CancelableSyncSocket stubs a bit more to compile and link. BUG=116317 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138007

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -32 lines)			Patch
M	base/sync_socket_nacl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ppapi/ppapi_proxy_untrusted.gypi	View	1	4 chunks	+6 lines, -5 lines	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.cc	View	1	4 chunks	+27 lines, -22 lines	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/thunk/resource_creation_api.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bbudge

We will need to implement SyncSocket for NaCl to make this work. For now it ...

8 years, 7 months ago (2012-05-18 22:46:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/10412014/10001

8 years, 7 months ago (2012-05-19 00:16:07 UTC) #3

Change committed as 138007

Expand Messages | Collapse Messages