Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 10412009: Enable disabled omnibox tests on aura (Closed)

Created:
8 years, 7 months ago by oshima
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Enable disabled omnibox tests on aura - SetText should move the cursor to the end of new tex. - OmniboxView::GetSelectionBounds should return the cursor position when there is no selection - Undo when ctrl-shift-z is pressed BUG=121558 TEST=OmniboxVitewTest::UndoRedo/BackspaceDeleteHalfWidthKatakana are enabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137992

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -49 lines) Patch
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 2 3 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 1 2 3 chunks +8 lines, -6 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/textfield/textfield_views_model_unittest.cc View 10 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
8 years, 7 months ago (2012-05-18 20:07:17 UTC) #1
sky
http://codereview.chromium.org/10412009/diff/2001/ui/views/controls/textfield/textfield_views_model.cc File ui/views/controls/textfield/textfield_views_model.cc (right): http://codereview.chromium.org/10412009/diff/2001/ui/views/controls/textfield/textfield_views_model.cc#newcode319 ui/views/controls/textfield/textfield_views_model.cc:319: size_t new_cursor = text.length(); Does this force scrolling when ...
8 years, 7 months ago (2012-05-18 20:28:30 UTC) #2
oshima
On 2012/05/18 20:28:30, sky wrote: > http://codereview.chromium.org/10412009/diff/2001/ui/views/controls/textfield/textfield_views_model.cc > File ui/views/controls/textfield/textfield_views_model.cc (right): > > http://codereview.chromium.org/10412009/diff/2001/ui/views/controls/textfield/textfield_views_model.cc#newcode319 > ...
8 years, 7 months ago (2012-05-18 20:50:50 UTC) #3
sky
LGTM
8 years, 7 months ago (2012-05-18 21:59:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10412009/8
8 years, 7 months ago (2012-05-18 22:10:31 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-19 00:17:51 UTC) #6
Change committed as 137992

Powered by Google App Engine
This is Rietveld 408576698