Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 10411098: Reland 138502 - Move version metadata from PluginGroup into PluginInstaller. (Closed)

Created:
8 years, 7 months ago by Bernhard Bauer
Modified:
8 years, 7 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, Aaron Boodman, arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org, stuartmorgan+watch_chromium.org, James Hawkins
Visibility:
Public.

Description

Reland 138502 - Move version metadata from PluginGroup into PluginInstaller. This also moves the plug-in information JSON files into their own subdirectory, so they can be changed without requiring OWNERS reviews for chrome/browser/resources (which is mostly WebUI otherwise). BUG=124396 TEST=PluginInstallerTest.SecurityStatus:PluginFinderTest.JsonSyntax TBR=jam@chromium.org,jhawkins@chromium.org Original review URL: https://chromiumcodereview.appspot.com/10263022 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138779

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+580 lines, -988 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_finder.cc View 1 chunk +26 lines, -5 lines 0 comments Download
M chrome/browser/plugin_finder_unittest.cc View 2 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/plugin_infobar_delegates.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/plugin_installer.h View 5 chunks +43 lines, -20 lines 0 comments Download
M chrome/browser/plugin_installer.cc View 6 chunks +70 lines, -20 lines 0 comments Download
A chrome/browser/plugin_installer_unittest.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/browser/plugin_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/plugin_info_message_filter.cc View 1 chunk +13 lines, -10 lines 0 comments Download
A chrome/browser/resources/plugin_metadata/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/plugin_metadata/plugins_linux.json View 1 chunk +116 lines, -0 lines 0 comments Download
A + chrome/browser/resources/plugin_metadata/plugins_mac.json View 7 chunks +73 lines, -21 lines 0 comments Download
A + chrome/browser/resources/plugin_metadata/plugins_win.json View 7 chunks +72 lines, -5 lines 0 comments Download
D chrome/browser/resources/plugins_linux.json View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/resources/plugins_mac.json View 1 chunk +0 lines, -190 lines 0 comments Download
D chrome/browser/resources/plugins_win.json View 1 chunk +0 lines, -185 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 8 chunks +46 lines, -30 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/plugin_group.h View 6 chunks +0 lines, -53 lines 0 comments Download
M webkit/plugins/npapi/plugin_group.cc View 5 chunks +4 lines, -93 lines 0 comments Download
M webkit/plugins/npapi/plugin_group_unittest.cc View 2 chunks +2 lines, -153 lines 0 comments Download
M webkit/plugins/npapi/plugin_list.cc View 3 chunks +23 lines, -110 lines 0 comments Download
M webkit/plugins/npapi/plugin_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Bernhard Bauer
Please review. The old version is in patch set 1, for comparison. win_aura compile failure ...
8 years, 7 months ago (2012-05-24 09:16:36 UTC) #1
jochen (gone - plz use gerrit)
lgtm On Thu, May 24, 2012 at 11:16 AM, <bauerb@chromium.org> wrote: > Reviewers: jochen, > ...
8 years, 7 months ago (2012-05-24 09:19:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10411098/4002
8 years, 7 months ago (2012-05-24 09:22:05 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-24 11:19:43 UTC) #4
Change committed as 138779

Powered by Google App Engine
This is Rietveld 408576698