Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: lib/compiler/implementation/ssa/types.dart

Issue 10411094: Fix bug in combination of bounded and exact types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/switch_this_test.dart » ('j') | tests/language/switch_this_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/types.dart
diff --git a/lib/compiler/implementation/ssa/types.dart b/lib/compiler/implementation/ssa/types.dart
index 8fdde0b0e044484acc9d43492bb5396228dec223..c9b37e80d9f7650730d260086b591be3723aa547 100644
--- a/lib/compiler/implementation/ssa/types.dart
+++ b/lib/compiler/implementation/ssa/types.dart
@@ -648,6 +648,9 @@ class HExactType extends HBoundedType {
if (other.isExact()) {
HExactType concrete = other;
if (this.type === concrete.type) return this;
+ } else if (other is HBoundedType) {
+ HBoundedType bounded = other;
+ if (this.type === bounded.type) return other;
ngeoffray 2012/05/23 14:09:45 This is OK for the union but not for the intersect
karlklose 2012/05/24 12:37:49 Done.
}
if (other.isUnknown()) return this;
return HType.CONFLICTING;
« no previous file with comments | « no previous file | tests/language/switch_this_test.dart » ('j') | tests/language/switch_this_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698