Issue 10411087: Don't use the 1px inset in NWW::GetClientAreaInsets() for shell windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10411087: Don't use the 1px inset in NWW::GetClientAreaInsets() for shell windows. (Closed)

Created:
8 years, 7 months ago by jeremya

Modified:
8 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org, benwells

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't use the 1px inset in NWW::GetClientAreaInsets() for shell windows. This fixes a problem when showing the custom shell window frame where 1px of the native windows frame peeks out below the custom frame. BUG=129293 R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138456

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	ui/views/widget/native_widget_win.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/10411087/1

8 years, 7 months ago (2012-05-23 05:13:42 UTC) #2

Change committed as 138456