Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 10411086: Makes the browser send pixels to the GPU process where it should (Closed)

Created:
8 years, 7 months ago by pkotwicz
Modified:
8 years, 7 months ago
Reviewers:
jamesr, sky, piman
CC:
chromium-reviews, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, jonathan.backer, Ian Vollick, dhollowa+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, James Su
Visibility:
Public.

Description

Makes the browser send pixels to the GPU process where it should. This patch fixes the places where we will be sending DIP to the GPU process but should be sending pixels instead to the GPU process once https://bugs.webkit.org/show_bug.cgi?id=86051 lands. This patch reverts: http://codereview.chromium.org/127553/ http://codereview.chromium.org/10332077/ Bug=127455, 114677 Test=Manual SchedulePaintInRect is called with parameters in DIP TBR=piman@chromium.org,sky@chromium.org,jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138510

Patch Set 1 #

Patch Set 2 : Fixed unittest #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -63 lines) Patch
A content/browser/renderer_host/dip_util.h View 1 chunk +40 lines, -0 lines 0 comments Download
A content/browser/renderer_host/dip_util.cc View 1 chunk +59 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 12 chunks +44 lines, -27 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/browser/render_widget_host_view.h View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M ui/compositor/layer.h View 2 chunks +9 lines, -7 lines 0 comments Download
M ui/compositor/layer.cc View 5 chunks +12 lines, -14 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pkotwicz
TBRing as I have migrated this issue from 10391074
8 years, 7 months ago (2012-05-23 01:43:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10411086/2001
8 years, 7 months ago (2012-05-23 02:31:59 UTC) #2
commit-bot: I haz the power
Try job failure for 10411086-2001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-23 03:02:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10411086/13001
8 years, 7 months ago (2012-05-23 14:10:27 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 17:06:10 UTC) #5
Failed to apply the patch.
Adding         content/browser/renderer_host/dip_util.cc
Adding         content/browser/renderer_host/dip_util.h
Sending        content/browser/renderer_host/render_widget_host_view_aura.cc
Sending        content/browser/renderer_host/render_widget_host_view_aura.h
Sending        content/browser/web_contents/web_contents_impl.cc
Sending        content/common/view_messages.h
Sending        content/content_browser.gypi
Sending        content/port/browser/render_widget_host_view_port.h
Sending        content/public/browser/render_widget_host_view.h
Sending        ui/compositor/layer.cc
Sending        ui/compositor/layer.h
Sending        ui/compositor/layer_unittest.cc
Sending        webkit/glue/webpreferences.cc
Sending        webkit/glue/webpreferences.h
Transmitting file data ..............svn: Commit failed (details follow):
svn: File '/trunk/src/content/content_browser.gypi' is out of date

Powered by Google App Engine
This is Rietveld 408576698