Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 10411068: Add hooks for mapping DSO library names. (Closed)

Created:
8 years, 7 months ago by halyavin
Modified:
8 years, 7 months ago
Reviewers:
eaeltsin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@nacl-stub
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : added files to correct folder #

Patch Set 3 : removed free_so_name #

Patch Set 4 : remove free_so_name prototype #

Total comments: 14

Patch Set 5 : fix style issues #

Total comments: 4

Patch Set 6 : updated comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M gdb/solib-svr4.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M gdb/solib-svr4.c View 1 2 3 4 5 6 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
halyavin
8 years, 7 months ago (2012-05-22 12:05:23 UTC) #1
halyavin
8 years, 7 months ago (2012-05-22 12:59:33 UTC) #2
eaeltsin
http://codereview.chromium.org/10411068/diff/6003/gdb/solib-svr4.c File gdb/solib-svr4.c (right): http://codereview.chromium.org/10411068/diff/6003/gdb/solib-svr4.c#newcode53 gdb/solib-svr4.c:53: static char* svr4_map_so_name(char *name); style: char *svr4_map http://codereview.chromium.org/10411068/diff/6003/gdb/solib-svr4.c#newcode2331 gdb/solib-svr4.c:2331: ...
8 years, 7 months ago (2012-05-22 13:07:20 UTC) #3
halyavin
http://codereview.chromium.org/10411068/diff/6003/gdb/solib-svr4.c File gdb/solib-svr4.c (right): http://codereview.chromium.org/10411068/diff/6003/gdb/solib-svr4.c#newcode53 gdb/solib-svr4.c:53: static char* svr4_map_so_name(char *name); On 2012/05/22 13:07:20, eaeltsin wrote: ...
8 years, 7 months ago (2012-05-22 13:19:37 UTC) #4
eaeltsin
8 years, 7 months ago (2012-05-22 13:48:10 UTC) #5
lgtm

Tiny nits below:

http://codereview.chromium.org/10411068/diff/8001/gdb/solib-svr4.c
File gdb/solib-svr4.c (right):

http://codereview.chromium.org/10411068/diff/8001/gdb/solib-svr4.c#newcode2331
gdb/solib-svr4.c:2331: /* Return real name of DSO library. */
/* Return real path for the given ld.so solib name.  */

http://codereview.chromium.org/10411068/diff/8001/gdb/solib-svr4.c#newcode2362
gdb/solib-svr4.c:2362: /* Set the function that maps DSO library names in the
ld.so internal structures
/* Set function to map ld.so solib names to real paths.  */

http://codereview.chromium.org/10411068/diff/8001/gdb/solib-svr4.c#newcode2396
gdb/solib-svr4.c:2396: /* Map a DSO library name in the ld.so internal
structures to a real path on the
/* Return real path for the given ld.so solib name.  */

http://codereview.chromium.org/10411068/diff/8001/gdb/solib-svr4.c#newcode2407
gdb/solib-svr4.c:2407: /* Return 1 if a DSO library name map function has been
defined,
/* Return 1 if a solib name

Powered by Google App Engine
This is Rietveld 408576698