TraversableMap only dependent on DescriptorArray

src/objects.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2457 matching lines @@
   // Initialize or change the enum cache,
   // using the supplied storage for the small "bridge".
   void SetEnumCache(FixedArray* bridge_storage,
                     FixedArray* new_cache,
                     Object* new_index_cache);
 
   // Accessors for fetching instance descriptor at descriptor number.
   inline String* GetKey(int descriptor_number);
   inline Object* GetValue(int descriptor_number);
   inline PropertyDetails GetDetails(int descriptor_number);
+
+  inline Object* RawGetValue(int descriptor_number);

[Michael Starzinger, 2012/05/24 14:02:25]

These methods are only needed by the IntrusiveMapTransitionIterator, can we move
them into that class (into the private section)? That prevents others from
accidentally using these methods.

Also I would rename them to GetRawValue and GetEawDetails which is more natural
sounding.

[Toon Verwaest, 2012/05/25 11:36:46]

Done.

+  inline PropertyDetails RawGetDetails(int descriptor_number);
+
   inline PropertyType GetType(int descriptor_number);
   inline int GetFieldIndex(int descriptor_number);
   inline JSFunction* GetConstantFunction(int descriptor_number);
   inline Object* GetCallbacksObject(int descriptor_number);
   inline AccessorDescriptor* GetCallbacks(int descriptor_number);
   inline bool IsProperty(int descriptor_number);
   inline bool IsTransitionOnly(int descriptor_number);
   inline bool IsNullDescriptor(int descriptor_number);
 
   class WhitenessWitness {
@@ skipping 155 matching lines @@
   static inline void NoIncrementalWriteBarrierSwap(
       FixedArray* array, int first, int second);
 
   // Swap descriptor first and second.
   inline void NoIncrementalWriteBarrierSwapDescriptors(
       int first, int second);
 
   FixedArray* GetContentArray() {
     return FixedArray::cast(get(kContentArrayIndex));
   }
+  inline FixedArray* RawGetContentArray();

[Michael Starzinger, 2012/05/24 14:02:25]

Likewise.

[Toon Verwaest, 2012/05/25 11:36:46]

Done.

   DISALLOW_IMPLICIT_CONSTRUCTORS(DescriptorArray);
 };
 
 
 // HashTable is a subclass of FixedArray that implements a hash table
 // that uses open addressing and quadratic probing.
 //
 // In order for the quadratic probing to work, elements that have not
 // yet been used and elements that have been deleted are
 // distinguished.  Probing continues when deleted elements are
@@ skipping 5984 matching lines @@
     } else {
       value &= ~(1 << bit_position);
     }
     return value;
   }
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_H_