Deprecate use of timezones.

Deprecate use of timezones.

Committed: https://code.google.com/p/dart/source/detail?r=7911

[floitsch, 2012-05-21 20:43:34]

This is a breaking change because fromEpoch now takes a different type for its
argument. Furthermore the timeZone field disappeared.
Some other methods have just been marked as deprecated. I would remove those ~1
week later.

[ngeoffray, 2012-05-22 08:58:45]

LGTM, please make sure to get another LGTM from the VM team before submitting.

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart
File corelib/src/date.dart (right):

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart#...
corelib/src/date.dart:81: * the given [timeZone].
Update comment

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart#...
corelib/src/date.dart:87: * comparison is independent of the time zone the
[Date] is in.
of whether the time is utc or in the local time zone.

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart#...
corelib/src/date.dart:114: * the local time zone. Otherwise, this method is
equvalent to
equivalent

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart#...
corelib/src/date.dart:120: * Returns [this] in UTC. Returns itself it is already
in UTC. Otherwise, this
itself *if* it is

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart#...
corelib/src/date.dart:121: * method is equvalent to [:new
Date.fromEpoch(this.value, isUtc: true):].
equivalent

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
File frog/lib/date_implementation.dart (right):

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
frog/lib/date_implementation.dart:19: return new
DateImplementation.withTimeZone(
If that one is deprecated, maybe don't use it.

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
frog/lib/date_implementation.dart:106: if (!(other is DateImplementation))
return false;
other is !DateImplementation

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
frog/lib/date_implementation.dart:127: if (isUtc()) return changeTimeZone(new
TimeZoneImplementation.local());
Don't use the deprecated method?

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
frog/lib/date_implementation.dart:133: return changeTimeZone(const
TimeZoneImplementation.utc());
ditto

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
frog/lib/date_implementation.dart:140: print(targetTimeZone.isUtc);
Remove print

https://chromiumcodereview.appspot.com/10411057/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/mockimpl.dart (right):

https://chromiumcodereview.appspot.com/10411057/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/mockimpl.dart:183: final bool _isUtcField;
remove the 'Field' suffix?

https://chromiumcodereview.appspot.com/10411057/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/mockimpl.dart:303: return new
Date.fromEpoch(value, targetTimeZone.isUtc);
Please deprecate TimeZone soon enough so that we don't get this mix of
getters/calls on isUtc

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart
File runtime/lib/date.dart (right):

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart#...
runtime/lib/date.dart:112: if (!(other is DateImplementation)) return false;
other is !

[Mads Ager (google), 2012-05-22 09:11:21]

LGTM with a couple of minor comments. I only looked at the three files in
runtime.

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart
File runtime/lib/date.dart (right):

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart#...
runtime/lib/date.dart:18: // JavaScript implementation of DateImplementation.
JavaScript? Not your code, but could you update? :-)

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart#...
runtime/lib/date.dart:20: final bool _isUtcField;
You should move the instance fields to the end of the class to make it
consistent with the class above.

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart#...
runtime/lib/date.dart:47: : this(years, month, day, hours, minutes, seconds,
milliseconds,
four-space indent as above. Not your code, but could you update?

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart#...
runtime/lib/date.dart:51: : _isUtcField = true,
Ditto.

[floitsch, 2012-05-22 14:50:38]

thanks for the reviews.

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart
File corelib/src/date.dart (right):

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart#...
corelib/src/date.dart:81: * the given [timeZone].
On 2012/05/22 08:58:45, ngeoffray wrote:
> Update comment

Done.

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart#...
corelib/src/date.dart:87: * comparison is independent of the time zone the
[Date] is in.
On 2012/05/22 08:58:45, ngeoffray wrote:
> of whether the time is utc or in the local time zone.

Done.

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart#...
corelib/src/date.dart:114: * the local time zone. Otherwise, this method is
equvalent to
On 2012/05/22 08:58:45, ngeoffray wrote:
> equivalent

Done.

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart#...
corelib/src/date.dart:120: * Returns [this] in UTC. Returns itself it is already
in UTC. Otherwise, this
On 2012/05/22 08:58:45, ngeoffray wrote:
> itself *if* it is

Done.

https://chromiumcodereview.appspot.com/10411057/diff/1/corelib/src/date.dart#...
corelib/src/date.dart:121: * method is equvalent to [:new
Date.fromEpoch(this.value, isUtc: true):].
On 2012/05/22 08:58:45, ngeoffray wrote:
> equivalent

Done.

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
File frog/lib/date_implementation.dart (right):

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
frog/lib/date_implementation.dart:19: return new
DateImplementation.withTimeZone(
On 2012/05/22 08:58:45, ngeoffray wrote:
> If that one is deprecated, maybe don't use it.

This is the frog-implementation of the library. Given its limited life-time I
kept the changes minimal.

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
frog/lib/date_implementation.dart:106: if (!(other is DateImplementation))
return false;
On 2012/05/22 08:58:45, ngeoffray wrote:
> other is !DateImplementation

Done.

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
frog/lib/date_implementation.dart:127: if (isUtc()) return changeTimeZone(new
TimeZoneImplementation.local());
On 2012/05/22 08:58:45, ngeoffray wrote:
> Don't use the deprecated method?

ditto.

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
frog/lib/date_implementation.dart:133: return changeTimeZone(const
TimeZoneImplementation.utc());
On 2012/05/22 08:58:45, ngeoffray wrote:
> ditto

ditto.

https://chromiumcodereview.appspot.com/10411057/diff/1/frog/lib/date_implemen...
frog/lib/date_implementation.dart:140: print(targetTimeZone.isUtc);
On 2012/05/22 08:58:45, ngeoffray wrote:
> Remove print

ouch.
done.

https://chromiumcodereview.appspot.com/10411057/diff/1/lib/compiler/implement...
File lib/compiler/implementation/lib/mockimpl.dart (right):

https://chromiumcodereview.appspot.com/10411057/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/mockimpl.dart:183: final bool _isUtcField;
On 2012/05/22 08:58:45, ngeoffray wrote:
> remove the 'Field' suffix?

Done.

https://chromiumcodereview.appspot.com/10411057/diff/1/lib/compiler/implement...
lib/compiler/implementation/lib/mockimpl.dart:303: return new
Date.fromEpoch(value, targetTimeZone.isUtc);
On 2012/05/22 08:58:45, ngeoffray wrote:
> Please deprecate TimeZone soon enough so that we don't get this mix of
> getters/calls on isUtc

Hopefully soon. The moment I get the OK for this CL I warn the mailing list, and
soon after I will remove these methods.

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart
File runtime/lib/date.dart (right):

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart#...
runtime/lib/date.dart:18: // JavaScript implementation of DateImplementation.
On 2012/05/22 09:11:22, Mads Ager wrote:
> JavaScript? Not your code, but could you update? :-)

It probably is my code :)
done.

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart#...
runtime/lib/date.dart:20: final bool _isUtcField;
On 2012/05/22 09:11:22, Mads Ager wrote:
> You should move the instance fields to the end of the class to make it
> consistent with the class above.

Done.

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart#...
runtime/lib/date.dart:47: : this(years, month, day, hours, minutes, seconds,
milliseconds,
On 2012/05/22 09:11:22, Mads Ager wrote:
> four-space indent as above. Not your code, but could you update?

Done.

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart#...
runtime/lib/date.dart:51: : _isUtcField = true,
On 2012/05/22 09:11:22, Mads Ager wrote:
> Ditto.

Done.

https://chromiumcodereview.appspot.com/10411057/diff/1/runtime/lib/date.dart#...
runtime/lib/date.dart:112: if (!(other is DateImplementation)) return false;
On 2012/05/22 08:58:45, ngeoffray wrote:
> other is !

Done.

[floitsch, 2012-05-23 16:00:39]

Found two more cases using the old API.

[ahe, 2012-05-23 16:02:08]

patchset 5: LGTM!

[ahe, 2012-06-07 10:11:02]

Just to let you know if a similar situation arises in the future.

https://chromiumcodereview.appspot.com/10411057/diff/10005/tests/co19/co19-le...
File tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/10411057/diff/10005/tests/co19/co19-le...
tests/co19/co19-leg.status:38: LibTest/core/Date/changeTimeZone_A01_t01: Skip
Please don't use skip. Also, please use "fail, pass" for tests that are failing
due to a bug in the test suite.

When you use skip, we don't detect crashes. Skip should only be used for
timeouts.