Finish file 'fuzzer' and fix issues.

runtime/bin/file.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/file.h"
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
@@ skipping 167 matching lines @@
 
 
 void FUNCTION_NAME(File_ReadList)(Dart_NativeArguments args) {
   Dart_EnterScope();
   intptr_t value =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 0));
   File* file = reinterpret_cast<File*>(value);
   ASSERT(file != NULL);
   Dart_Handle buffer_obj = Dart_GetNativeArgument(args, 1);
   ASSERT(Dart_IsList(buffer_obj));
+  // Offset and length arguments are checked in Dart code to be
+  // integers and have the property that (offset + length) <=
+  // list.length. Therefore, it is safe to extract their value as
+  // 64-bit integers.
   int64_t offset =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 2));
   int64_t length =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 3));
   intptr_t array_len = 0;
   Dart_Handle result = Dart_ListLength(buffer_obj, &array_len);
   if (Dart_IsError(result)) Dart_PropagateError(result);
   ASSERT((offset + length) <= array_len);
   uint8_t* buffer = new uint8_t[length];
   int bytes_read = file->Read(reinterpret_cast<void*>(buffer), length);
@@ skipping 15 matching lines @@
 
 
 void FUNCTION_NAME(File_WriteList)(Dart_NativeArguments args) {
   Dart_EnterScope();
   intptr_t value =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 0));
   File* file = reinterpret_cast<File*>(value);
   ASSERT(file != NULL);
   Dart_Handle buffer_obj = Dart_GetNativeArgument(args, 1);
   ASSERT(Dart_IsList(buffer_obj));
+  // Offset and length arguments are checked in Dart code to be
+  // integers and have the property that (offset + length) <=
+  // list.length. Therefore, it is safe to extract their value as
+  // 64-bit integers.
   int64_t offset =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 2));
   int64_t length =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 3));
   intptr_t buffer_len = 0;
   Dart_Handle result = Dart_ListLength(buffer_obj, &buffer_len);
   if (Dart_IsError(result)) Dart_PropagateError(result);
   ASSERT((offset + length) <= buffer_len);
   uint8_t* buffer = new uint8_t[length];
   result = Dart_ListGetAsBytes(buffer_obj, offset, buffer, length);
@@ skipping 56 matching lines @@
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(File_Truncate)(Dart_NativeArguments args) {
   Dart_EnterScope();
   intptr_t value =
       DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 0));
   File* file = reinterpret_cast<File*>(value);
   ASSERT(file != NULL);
-  int64_t length =
-      DartUtils::GetIntegerValue(Dart_GetNativeArgument(args, 1));
-  if (file->Truncate(length)) {
-    Dart_SetReturnValue(args, Dart_True());
+  int64_t length = 0;
+  if (DartUtils::GetInt64Value(Dart_GetNativeArgument(args, 1), &length)) {
+    if (file->Truncate(length)) {
+      Dart_SetReturnValue(args, Dart_True());
+    } else {
+      Dart_Handle err = DartUtils::NewDartOSError();
+      if (Dart_IsError(err)) Dart_PropagateError(err);
+      Dart_SetReturnValue(args, err);
+    }
   } else {
-    Dart_Handle err = DartUtils::NewDartOSError();
+    OSError os_error(-1, "Invalid argument", OSError::kUnknown);
+    Dart_Handle err = DartUtils::NewDartOSError(&os_error);
     if (Dart_IsError(err)) Dart_PropagateError(err);
     Dart_SetReturnValue(args, err);
   }
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(File_Length)(Dart_NativeArguments args) {
   Dart_EnterScope();
   intptr_t value =
@@ skipping 611 matching lines @@
   Dart_EnterScope();
   Dart_SetReturnValue(args, Dart_Null());
   Dart_Port service_port = File::GetServicePort();
   if (service_port != kIllegalPort) {
     // Return a send port for the service port.
     Dart_Handle send_port = Dart_NewSendPort(service_port);
     Dart_SetReturnValue(args, send_port);
   }
   Dart_ExitScope();
 }