Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 10411039: Fixing the socket state update issue in IpcPacketSocket (Closed)

Created:
8 years, 7 months ago by Mallinath (Gone from Chromium)
Modified:
8 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

contributed by mallinath@chromium.org libjingle expects socket state to be in BOUNDED when it receives SignalAddressReady. But chrome does the state change after signal is delivered. Changed state to BOUND before signal is sent. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/renderer/p2p/ipc_socket_factory.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mallinath (Gone from Chromium)
8 years, 7 months ago (2012-05-19 01:20:51 UTC) #1
Mallinath (Gone from Chromium)
8 years, 7 months ago (2012-05-19 06:48:50 UTC) #2
Sergey Ulanov
lgtm
8 years, 7 months ago (2012-05-21 05:29:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mallinath@chromium.org/10411039/1
8 years, 7 months ago (2012-05-21 05:48:19 UTC) #4
commit-bot: I haz the power
Try job failure for 10411039-1 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-05-21 07:07:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mallinath@chromium.org/10411039/1
8 years, 7 months ago (2012-05-21 14:28:25 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-21 20:15:39 UTC) #7
The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is win_rel, revision is 138129, job name
was 10411039-1 (retry) (retry) (retry) (retry).

Powered by Google App Engine
This is Rietveld 408576698