Separate BrowserWindow from Panel class.

Separate BrowserWindow from Panel class.

New PanelBrowserWindow class contains the BrowserWindow interface used by the browser to interact with Panels. Panel is now a BaseWindow.

First step of many in the Panel refactor.

BUG=127323
TEST=All existing tests still pass.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138310

[jennb, 2012-05-21 21:11:05]

This patch is basically a code move.

[Ben Goodger (Google), 2012-05-21 21:38:43]

http://codereview.chromium.org/10411036/diff/10001/chrome/browser/ui/panels/p...
File chrome/browser/ui/panels/panel_browser_window.h (right):

http://codereview.chromium.org/10411036/diff/10001/chrome/browser/ui/panels/p...
chrome/browser/ui/panels/panel_browser_window.h:27: class PanelBrowserWindow :
public BrowserWindow,
why do you need this?

[jennb, 2012-05-21 21:44:54]

http://codereview.chromium.org/10411036/diff/10001/chrome/browser/ui/panels/p...
File chrome/browser/ui/panels/panel_browser_window.h (right):

http://codereview.chromium.org/10411036/diff/10001/chrome/browser/ui/panels/p...
chrome/browser/ui/panels/panel_browser_window.h:27: class PanelBrowserWindow :
public BrowserWindow,
On 2012/05/21 21:38:43, Ben Goodger (Google) wrote:
> why do you need this?

I haven't removed any logic that depends on BrowserWindow yet. I've simply
separated out the BrowserWindow dependency from Panel class for now. Next steps
will begin removing rest of Browser logic from Panel class, building out
replacement logic for hosting web content, etc.

[Ben Goodger (Google), 2012-05-21 21:46:31]

On 2012/05/21 21:44:54, jennb wrote:
> I haven't removed any logic that depends on BrowserWindow yet. I've simply
> separated out the BrowserWindow dependency from Panel class for now. Next
steps
> will begin removing rest of Browser logic from Panel class, building out
> replacement logic for hosting web content, etc.

I see. So each Panel will have an instance of one of these objects?

[jennb, 2012-05-21 21:49:26]

On 2012/05/21 21:46:31, Ben Goodger (Google) wrote:
> On 2012/05/21 21:44:54, jennb wrote:
> > I haven't removed any logic that depends on BrowserWindow yet. I've simply
> > separated out the BrowserWindow dependency from Panel class for now. Next
> steps
> > will begin removing rest of Browser logic from Panel class, building out
> > replacement logic for hosting web content, etc.
> 
> I see. So each Panel will have an instance of one of these objects?

Yes. PanelBrowserWindow will eventually be deleted once we have a replacement
for hosting web content. I've shared the design doc with you and Steven for more
details.

[Ben Goodger (Google), 2012-05-21 21:52:56]

lgtm

[stevenjb, 2012-05-21 22:00:57]

lgtm

[Dmitry Titov, 2012-05-21 22:43:26]

lgtm

[commit-bot: I haz the power, 2012-05-21 22:46:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10411036/10001

[commit-bot: I haz the power, 2012-05-22 02:40:01]

Try job failure for 10411036-10001 (retry) on win_rel for steps "base_unittests,
sync_unit_tests" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-05-22 16:46:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jennb@chromium.org/10411036/10001

[commit-bot: I haz the power, 2012-05-22 18:29:55]

Try job failure for 10411036-10001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...