Fixing loglevel in chrome driver to accept string rather than an integer.

chrome/test/webdriver/webdriver_logging.cc

Index: chrome/test/webdriver/webdriver_logging.cc
diff --git a/chrome/test/webdriver/webdriver_logging.cc b/chrome/test/webdriver/webdriver_logging.cc
index feae90cc7ff23a39614eab4b08b2ef38ba2428ae..54280825fbbb63a15b12a40e4a4c001d0988ae68 100644
--- a/chrome/test/webdriver/webdriver_logging.cc
+++ b/chrome/test/webdriver/webdriver_logging.cc
@@ -24,6 +24,21 @@ FileLog* FileLog::singleton_ = NULL;
 
 double start_time = 0;
 
+LogLevel LogLevelFromString(const std::string& name) {
+  // Default logging level is INFO.
+  LogLevel level = kInfoLogLevel;

[kkania, 2012/05/21 17:46:46]

If they pass "OFF", this will get set to INFO, which I think is wrong. I think
we should set CONFIG->INFO, FINEST->FINER, and handle ALL and OFF correctly.

[zori, 2012/05/21 23:42:33]

I think FINEST->ALL.

On 2012/05/21 17:46:46, kkania wrote:

+  if (name == "SEVERE") {

[kkania, 2012/05/21 17:46:46]

although the doc seems to suggest it will be caps, it doesn't say explicitly. i
think an case insensitive compare would be better. what do you think?

[zori, 2012/05/21 23:42:33]

Done.

+    level = kSevereLogLevel;
+  } else if (name == "WARNING") {
+    level = kWarningLogLevel;
+  } else if (name == "FINE") {
+    level = kFineLogLevel;
+  } else if (name == "FINER") {
+    level = kFinerLogLevel;
+  }
+  return level;
+}
+
 // static
 bool LogType::FromString(const std::string& name, LogType* log_type) {
   if (name == "driver") {