Fixing loglevel in chrome driver to accept string rather than an integer.

chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc

Index: chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc
diff --git a/chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc b/chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc
index 085c0b9e2fe98ab3344d1d1d213b296514de30a9..0f01d790d1ed9d6be7cf412fa7144b39335da6e3 100644
--- a/chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc
+++ b/chrome/test/webdriver/webdriver_capabilities_parser_unittest.cc
@@ -259,4 +259,23 @@ TEST(CapabilitiesParser, ProxyFtpServerCapNullValue) {
       caps.command.GetSwitchValueASCII(switches::kProxyServer).c_str());
 }
 
+// To demonstrate a bug (described:
+// http://code.google.com/p/chromedriver/issues/detail?id=75),
+// namely, that the driver logging preference should be of type Level, not
+// integer
+// (http://code.google.com/p/selenium/wiki/DesiredCapabilities#JSON_object)
+TEST(CapabilitiesParser, DriverLoggingCapString) {
+  Capabilities caps;
+  DictionaryValue dict;
+  DictionaryValue* options = new DictionaryValue();
+  dict.Set("loggingPrefs", options);
+  CapabilitiesParser parser(&dict, FilePath(), Logger(), &caps);
+
+  options->SetString("driver", "INFO");
+  ASSERT_FALSE(parser.Parse());

[kkania, 2012/05/21 17:46:46]

i guess you wrote this test to demonstrate the bug. You need to change it now to
pass for the correct behavior.

[zori, 2012/05/21 23:42:33]

Since CapabilitiesParser::Parse() returns Error*, this is how the correct
behavior is. Changing the comments.
On 2012/05/21 17:46:46, kkania wrote:

+
+  options->SetInteger("driver", kInfoLogLevel);

[kkania, 2012/05/21 17:46:46]

although people forget to all the time, technically you need to include
"chrome/test/webdriver/webdriver_logging.h" for this constant. You shouldn't
rely on transitive includes (one exception (i think optional) is if it's
included in the associated header, you don't have to include it in your .cc).

[zori, 2012/05/21 23:42:33]

I knew this, sorry. Done.
On 2012/05/21 17:46:46, kkania wrote:

+  ASSERT_TRUE(parser.Parse());
+}
+
 }  // namespace webdriver