Fixing loglevel in chrome driver to accept string rather than an integer.

chrome/test/webdriver/webdriver_logging.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/webdriver/webdriver_logging.h"
 
 #include <cmath>
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
 #include "base/stringprintf.h"
 #include "base/time.h"
 #include "build/build_config.h"
 
 using base::DictionaryValue;
 using base::ListValue;
 using base::Value;
 
 namespace webdriver {
 
 FileLog* FileLog::singleton_ = NULL;
 
 double start_time = 0;
 
+LogLevel LogLevelFromString(const std::string& name) {
+  // Default logging level is INFO.
+  LogLevel level = kInfoLogLevel;

[kkania, 2012/05/21 17:46:46]

If they pass "OFF", this will get set to INFO, which I think is wrong. I think
we should set CONFIG->INFO, FINEST->FINER, and handle ALL and OFF correctly.

[zori, 2012/05/21 23:42:33]

I think FINEST->ALL.

On 2012/05/21 17:46:46, kkania wrote:

+  if (name == "SEVERE") {

[kkania, 2012/05/21 17:46:46]

although the doc seems to suggest it will be caps, it doesn't say explicitly. i
think an case insensitive compare would be better. what do you think?

[zori, 2012/05/21 23:42:33]

Done.

+    level = kSevereLogLevel;
+  } else if (name == "WARNING") {
+    level = kWarningLogLevel;
+  } else if (name == "FINE") {
+    level = kFineLogLevel;
+  } else if (name == "FINER") {
+    level = kFinerLogLevel;
+  }
+  return level;
+}
+
 // static
 bool LogType::FromString(const std::string& name, LogType* log_type) {
   if (name == "driver") {
     *log_type = LogType(kDriver);
   } else {
     return false;
   }
   return true;
 }
 
@@ skipping 184 matching lines @@
     log = FileLog::CreateFileLog(FILE_PATH_LITERAL("chromedriver.log"),
                                  min_log_level);
   } else {
     log = new FileLog(log_path, min_log_level);
   }
   FileLog::SetGlobalLog(log);
   return log->IsOpen();
 }
 
 }  // namespace webdriver