Issue 10411022: Change bug for disabled RemoteFileSystemExtensionApiTest.RemoteMountPoint test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10411022: Change bug for disabled RemoteFileSystemExtensionApiTest.RemoteMountPoint test. (Closed)

Created:
8 years, 7 months ago by tbarzic

Modified:
8 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable failing RemoteFileSystemExtensionApiTest.RemoteMountPoint test. Also, patch contains a fix for a bug where file size was not set correctly in document feed. We will also need a WebKit patch to fix the test, so until that is in, I'm disabling the test. *NOTE: I was beaten with disabling the test, but still landing this, since it contains some fixes :) TEST=None BUG=128759 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137907

Patch Set 1 #

Total comments: 1

Patch Set 2 : added bug #

Patch Set 3 : rebase #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
M	chrome/browser/chromeos/extensions/external_filesystem_apitest.cc	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/test/data/chromeos/gdata/remote_file_system_apitest_root_feed.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/filebrowser_component/remote.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tbarzic

PTaL http://codereview.chromium.org/10411022/diff/1/chrome/test/data/extensions/api_test/filebrowser_component/remote.js File chrome/test/data/extensions/api_test/filebrowser_component/remote.js (right): http://codereview.chromium.org/10411022/diff/1/chrome/test/data/extensions/api_test/filebrowser_component/remote.js#newcode126 chrome/test/data/extensions/api_test/filebrowser_component/remote.js:126: TestRunner.prototype.errorCallback_ = function(messagePrefix, error) { failure output should ...

8 years, 7 months ago (2012-05-18 17:52:14 UTC) #1

LGTM

Expand Messages | Collapse Messages