Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 10411017: Fix testGuestModeEnabled by adding missing import (Closed)

Created:
8 years, 7 months ago by bartfab (slow)
Modified:
8 years, 7 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix testGuestModeEnabled by adding missing import This CL adds a missing import to unbreak the test on BVT. BUG=128343 TEST=testGuestModeEnabled going through code path that uses logging.warn Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
chrome/test/functional/chromeos_device_policy.py View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bartfab (slow)
Hi Nirnimesh, could you please review? The test is failing on BVT because I forgot ...
8 years, 7 months ago (2012-05-18 12:15:04 UTC) #1
Nirnimesh
Diff is missing. Could you re-upload?
8 years, 7 months ago (2012-05-18 18:39:53 UTC) #2
Nirnimesh
Unified diff is visible. LGTM
8 years, 7 months ago (2012-05-18 18:41:01 UTC) #3
bartfab (slow)
Weird thing about the diff. I wonder how that happened.
8 years, 7 months ago (2012-05-18 19:39:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/10411017/1
8 years, 7 months ago (2012-05-18 19:39:48 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-18 20:57:26 UTC) #6
Change committed as 137955

Powered by Google App Engine
This is Rietveld 408576698