Chromium Code Reviews| OLD | NEW | 
|---|---|
| 1 // Copyright 2012 the V8 project authors. All rights reserved. | 1 // Copyright 2012 the V8 project authors. All rights reserved. | 
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without | 
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are | 
| 4 // met: | 4 // met: | 
| 5 // | 5 // | 
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright | 
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. | 
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above | 
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following | 
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided | 
| (...skipping 1090 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1101 } | 1101 } | 
| 1102 } | 1102 } | 
| 1103 | 1103 | 
| 1104 if (new_range != NULL && !new_range->IsMostGeneric()) { | 1104 if (new_range != NULL && !new_range->IsMostGeneric()) { | 
| 1105 AddRange(value, new_range); | 1105 AddRange(value, new_range); | 
| 1106 } | 1106 } | 
| 1107 } | 1107 } | 
| 1108 | 1108 | 
| 1109 | 1109 | 
| 1110 void HRangeAnalysis::InferRange(HValue* value) { | 1110 void HRangeAnalysis::InferRange(HValue* value) { | 
| 1111 ASSERT(!value->HasRange()); | 1111 ASSERT(value->CheckFlag(HValue::kHasPreinitializedRange) | 
| 1112 || !value->HasRange()); | |
| 
 
Florian Schneider
2012/05/18 16:12:06
Can't you just check HasRange() here and leave it
 
 | |
| 1112 if (!value->representation().IsNone()) { | 1113 if (!value->representation().IsNone()) { | 
| 1113 value->ComputeInitialRange(zone_); | 1114 value->ComputeInitialRange(zone_); | 
| 1114 Range* range = value->range(); | 1115 Range* range = value->range(); | 
| 1115 TraceRange("Initial inferred range of %d (%s) set to [%d,%d]\n", | 1116 TraceRange("Initial inferred range of %d (%s) set to [%d,%d]\n", | 
| 1116 value->id(), | 1117 value->id(), | 
| 1117 value->Mnemonic(), | 1118 value->Mnemonic(), | 
| 1118 range->lower(), | 1119 range->lower(), | 
| 1119 range->upper()); | 1120 range->upper()); | 
| 1120 } | 1121 } | 
| 1121 } | 1122 } | 
| (...skipping 7738 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 8860 } | 8861 } | 
| 8861 } | 8862 } | 
| 8862 | 8863 | 
| 8863 #ifdef DEBUG | 8864 #ifdef DEBUG | 
| 8864 if (graph_ != NULL) graph_->Verify(false); // No full verify. | 8865 if (graph_ != NULL) graph_->Verify(false); // No full verify. | 
| 8865 if (allocator_ != NULL) allocator_->Verify(); | 8866 if (allocator_ != NULL) allocator_->Verify(); | 
| 8866 #endif | 8867 #endif | 
| 8867 } | 8868 } | 
| 8868 | 8869 | 
| 8869 } } // namespace v8::internal | 8870 } } // namespace v8::internal | 
| OLD | NEW |