Issue 10411010: [Gtk, WebIntents] Support autosizing of inline content.

Issue 10411010: [Gtk, WebIntents] Support autosizing of inline content. (Closed)

Created:
8 years, 7 months ago by groby-ooo-7-16

Modified:
8 years, 7 months ago

Reviewers:
Greg Billock, Evan Stade

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Gtk, WebIntents] Support autosizing of inline content. BUG=128089 TEST=Select an intent with inline disposition, watch picker resize Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138172

Patch Set 1 #

Total comments: 2

Patch Set 2 : Switch from hbox to alignment. #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -10 lines)			Patch
M	chrome/browser/ui/gtk/web_intent_picker_gtk.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/web_intent_picker_gtk.cc	View	1	2 chunks	+14 lines, -5 lines	1 comment	Download
M	chrome/browser/ui/intents/web_intent_inline_disposition_delegate.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc	View		3 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker.cc	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

https://chromiumcodereview.appspot.com/10411010/diff/1/chrome/browser/ui/gtk/web_intent_picker_gtk.cc File chrome/browser/ui/gtk/web_intent_picker_gtk.cc (right): https://chromiumcodereview.appspot.com/10411010/diff/1/chrome/browser/ui/gtk/web_intent_picker_gtk.cc#newcode269 chrome/browser/ui/gtk/web_intent_picker_gtk.cc:269: GtkWidget* content_hbox_ = gtk_hbox_new(FALSE, ui::kControlSpacing); use an alignment for ...

8 years, 7 months ago (2012-05-18 20:35:19 UTC) #2

groby-ooo-7-16

Evan: GTK fix is in. https://chromiumcodereview.appspot.com/10411010/diff/1/chrome/browser/ui/gtk/web_intent_picker_gtk.cc File chrome/browser/ui/gtk/web_intent_picker_gtk.cc (right): https://chromiumcodereview.appspot.com/10411010/diff/1/chrome/browser/ui/gtk/web_intent_picker_gtk.cc#newcode269 chrome/browser/ui/gtk/web_intent_picker_gtk.cc:269: GtkWidget* content_hbox_ = gtk_hbox_new(FALSE, ...

8 years, 7 months ago (2012-05-18 21:07:22 UTC) #4

Evan Stade

https://chromiumcodereview.appspot.com/10411010/diff/2003/chrome/browser/ui/gtk/web_intent_picker_gtk.cc File chrome/browser/ui/gtk/web_intent_picker_gtk.cc (right): https://chromiumcodereview.appspot.com/10411010/diff/2003/chrome/browser/ui/gtk/web_intent_picker_gtk.cc#newcode245 chrome/browser/ui/gtk/web_intent_picker_gtk.cc:245: gtk_util::RemoveAllChildren(contents_); try removing all children from sub_contents instead to ...

8 years, 7 months ago (2012-05-18 21:16:07 UTC) #5

Evan Stade

ok, lgtm, although I think this file could be a bit simpler.

8 years, 7 months ago (2012-05-18 21:44:44 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10411010/2003

8 years, 7 months ago (2012-05-21 18:03:49 UTC) #7

commit-bot: I haz the power

8 years, 7 months ago (2012-05-21 21:33:09 UTC) #8

Try job failure for 10411010-2003 (retry) on win_rel for steps "base_unittests,
sync_unit_tests".
It's a second try, previously, steps "base_unittests, sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Expand Messages | Collapse Messages