Workaround: Wrap IBusText with ibus namespace.

Workaround: Wrap IBusText with ibus namespace.

To avoid conflict existing IBusText which is defined in ibus.h, wrap ibus
namespace. This is just workaround and will remove after complete libibus
removal.

TEST=ui_unittests,unit_tests,dbus_unittests,chromeos_unittests
BUG=126947
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137821

[satorux1, 2012-05-18 00:37:31]

I'm confused. The code is already in chromeos namespace. What's the benefit of
adding 'ibus' namespace?

Besides, even if the namespace is separate, using the same class name (IBusText)
may be still confusing. You might want to rename this to something like
NonaIBusText

[Seigo Nonaka, 2012-05-18 00:51:07]

Okay, I will make renaming CL.

[satorux1, 2012-05-18 01:01:52]

On 2012/05/18 00:51:07, Seigo Nonaka wrote:
> Okay, I will make renaming CL.

What was the benefit of the "ibus" namespace?

[Seigo Nonaka, 2012-05-18 01:06:52]

In
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/chromeos/in...,
the libibus's IBusText is used in chromeos namespace.

In above context, the IBusText means chromeos::IBusText, so compile will fail
due to type mismatch.

We may have choice:
1) Introduce ibus namespace like this CL.
2) Rename IBusText to ChromeIBusText or something like that.
3) Add global scope resolving operator "::" into libibus's IBusText.

What do you think of?

On 2012/05/18 01:01:52, satorux1 wrote:
> On 2012/05/18 00:51:07, Seigo Nonaka wrote:
> > Okay, I will make renaming CL.
> 
> What was the benefit of the "ibus" namespace?

[satorux1, 2012-05-18 01:14:38]

On 2012/05/18 01:06:52, Seigo Nonaka wrote:
> In
>
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/chromeos/in...,
> the libibus's IBusText is used in chromeos namespace.
> 
> In above context, the IBusText means chromeos::IBusText, so compile will fail
> due to type mismatch.
> 
> We may have choice:
> 1) Introduce ibus namespace like this CL.
> 2) Rename IBusText to ChromeIBusText or something like that.
> 3) Add global scope resolving operator "::" into libibus's IBusText.
> 
> What do you think of?

Now I understand the problem... I'm ok with 1).



> 
> On 2012/05/18 01:01:52, satorux1 wrote:
> > On 2012/05/18 00:51:07, Seigo Nonaka wrote:
> > > Okay, I will make renaming CL.
> > 
> > What was the benefit of the "ibus" namespace?

[satorux1, 2012-05-18 01:15:14]

LGTM. Don't need to rename the class for now.

[commit-bot: I haz the power, 2012-05-18 02:53:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/10411006/1

[commit-bot: I haz the power, 2012-05-18 04:13:39]

Change committed as 137821