Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 10411002: Implement the Chromium-specific part of WebCore context menus with submenus (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/glue/webmenuitem.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/render_view_context_menu.cc
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index 54fdbf858c14677ed77ea4fe73d5556adafc6c4e..7a7f97e27d4b3e15089d3137b6be744503059279 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -179,13 +179,10 @@ void AddCustomItemsToMenu(const std::vector<WebMenuItem>& items,
items[i].action + IDC_CONTENT_CONTEXT_CUSTOM_FIRST,
items[i].label);
break;
- case WebMenuItem::GROUP:
- // TODO(viettrungluu): I don't know what this is supposed to do.
- NOTREACHED();
- break;
case WebMenuItem::SEPARATOR:
menu_model->AddSeparator();
break;
+ case WebMenuItem::GROUP:
pfeldman 2012/05/22 14:22:30 why did this change?
case WebMenuItem::SUBMENU: {
ui::SimpleMenuModel* submenu = new ui::SimpleMenuModel(delegate);
AddCustomItemsToMenu(items[i].submenu, depth + 1, total_items, delegate,
« no previous file with comments | « no previous file | webkit/glue/webmenuitem.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698