Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 10411002: Implement the Chromium-specific part of WebCore context menus with submenus (Closed)

Created:
8 years, 7 months ago by apavlov
Modified:
8 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Implement the Chromium-specific part of WebCore context menus with submenus. The WebKit counterpart is tracked at https://bugs.webkit.org/show_bug.cgi?id=86625 BUG=128351 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138540

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove unneeded change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webkit/glue/webmenuitem.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
apavlov
Folks, Could you have a look at this patch? Its WebKit counterpart is up for ...
8 years, 7 months ago (2012-05-18 17:33:29 UTC) #1
pfeldman
https://chromiumcodereview.appspot.com/10411002/diff/1/chrome/browser/tab_contents/render_view_context_menu.cc File chrome/browser/tab_contents/render_view_context_menu.cc (right): https://chromiumcodereview.appspot.com/10411002/diff/1/chrome/browser/tab_contents/render_view_context_menu.cc#newcode185 chrome/browser/tab_contents/render_view_context_menu.cc:185: case WebMenuItem::GROUP: why did this change?
8 years, 7 months ago (2012-05-22 14:22:29 UTC) #2
pfeldman
lgtm
8 years, 7 months ago (2012-05-22 14:49:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/10411002/4001
8 years, 7 months ago (2012-05-23 09:16:11 UTC) #4
commit-bot: I haz the power
Presubmit check for 10411002-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-23 09:16:15 UTC) #5
apavlov
Dear src/webkit OWNERS, Can you please lgtm this change? Thanks!
8 years, 7 months ago (2012-05-23 09:18:55 UTC) #6
tony
LGTM
8 years, 7 months ago (2012-05-23 16:12:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/10411002/4001
8 years, 7 months ago (2012-05-23 16:21:57 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 18:39:59 UTC) #9
Change committed as 138540

Powered by Google App Engine
This is Rietveld 408576698