[FileBrowser] Fixed tab navigation for detail-thumbnail-settings buttons.

[FileBrowser] Fixed tab navigation for detail-thumbnail-settings buttons.


BUG=10411018
TEST=Manual: notice that tab navigation now always works for buttons in top-right corner of filebrowser(earlier it didn't work after showing-hiding any modal dialog).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138477

[Dmitry Zvorygin, 2012-05-23 13:59:39]

PTAL.

[dgozman, 2012-05-23 14:44:41]

LGTM

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/css/file_manager.css:449: /* When
detail-view is not disabled(thus thumbnail view is disabled), push
space before (

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/js/file_manager.js:664:
.querySelector('#thumbnail-view');
Binary operators (including dot) should be before line break.

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/js/file_manager.js:3853:
this.thumbnailViewButton_.focus();
Revert this as discussed offline.

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
File chrome/browser/resources/file_manager/main.html (right):

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/main.html:157: menu="#docs-settings"
visibleif="full-page" >
extra space

[Dmitry Zvorygin, 2012-05-23 14:51:58]

Fixed comments.

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/css/file_manager.css:449: /* When
detail-view is not disabled(thus thumbnail view is disabled), push
On 2012/05/23 14:44:41, dgozman wrote:
> space before (

Done.

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/js/file_manager.js:664:
.querySelector('#thumbnail-view');
On 2012/05/23 14:44:41, dgozman wrote:
> Binary operators (including dot) should be before line break.

Done.

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/js/file_manager.js:3853:
this.thumbnailViewButton_.focus();
On 2012/05/23 14:44:41, dgozman wrote:
> Revert this as discussed offline.

Done.

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
File chrome/browser/resources/file_manager/main.html (right):

http://codereview.chromium.org/10409093/diff/1/chrome/browser/resources/file_...
chrome/browser/resources/file_manager/main.html:157: menu="#docs-settings"
visibleif="full-page" >
On 2012/05/23 14:44:41, dgozman wrote:
> extra space

Done.

[commit-bot: I haz the power, 2012-05-23 14:53:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zvorygin@chromium.org/10409093/6001