Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: content/public/browser/web_contents.h

Issue 10409088: Get rid of the RenderViewType concept in content, since it was only used by Chrome. Store the enum… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
===================================================================
--- content/public/browser/web_contents.h (revision 138369)
+++ content/public/browser/web_contents.h (working copy)
@@ -14,7 +14,6 @@
#include "content/public/browser/page_navigator.h"
#include "content/public/browser/save_page_type.h"
#include "content/public/browser/web_ui.h"
-#include "content/public/common/view_type.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/gfx/native_widget_types.h"
#include "webkit/glue/window_open_disposition.h"
@@ -67,7 +66,8 @@
// Returns a WebContents that wraps the RenderViewHost, or NULL if the
// render view host's delegate isn't a WebContents.
- CONTENT_EXPORT static WebContents* FromRenderViewHost(RenderViewHost* rvh);
+ CONTENT_EXPORT static WebContents* FromRenderViewHost(
+ const RenderViewHost* rvh);
virtual ~WebContents() {}
@@ -91,10 +91,6 @@
// NavigationController).
virtual content::BrowserContext* GetBrowserContext() const = 0;
- // Allows overriding the type of this tab.
- virtual void SetViewType(content::ViewType type) = 0;
- virtual content::ViewType GetViewType() const = 0;
-
// Gets the URL that is currently being displayed, if there is one.
virtual const GURL& GetURL() const = 0;

Powered by Google App Engine
This is Rietveld 408576698