Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 10409086: Quieter cab extraction (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Quieter cab extraction Suppress stdout of 'expand' command unless there's an error. i.e. """ [2294->7960/10271 ~17] ACTION content_common: extract_xinput Microsoft (R) File Expansion Utility Version 6.1.7600.16385 Copyright (c) Microsoft Corporation. All rights reserved. Adding ../out/Debug\tmpamaser\xinput1_3.dll to Extraction Queue Expanding Files .... Expanding Files Complete ... [2164->8090/10271 ~17] ACTION content_gpu: extract_d3dx9 Microsoft (R) File Expansion Utility Version 6.1.7600.16385 Copyright (c) Microsoft Corporation. All rights reserved. Adding ../out/Debug\tmpcxuoz9\d3dx9_43.dll to Extraction Queue Expanding Files .... Expanding Files Complete ... [2163->8091/10271 ~17] ACTION content_gpu: extract_d3dcompiler Microsoft (R) File Expansion Utility Version 6.1.7600.16385 Copyright (c) Microsoft Corporation. All rights reserved. Adding ../out/Debug\tmploys57\D3DCompiler_43.dll to Extraction Queue Expanding Files .... Expanding Files Complete ... """ R=apatrick@chromium.org BUG=126483 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M build/extract_from_cab.py View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
8 years, 7 months ago (2012-05-23 00:06:39 UTC) #1
apatrick_chromium
lgtm
8 years, 7 months ago (2012-05-23 00:12:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10409086/1
8 years, 7 months ago (2012-05-23 02:14:44 UTC) #3
commit-bot: I haz the power
Try job failure for 10409086-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-23 02:40:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10409086/1
8 years, 7 months ago (2012-05-23 05:14:11 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 07:09:00 UTC) #6
Change committed as 138442

Powered by Google App Engine
This is Rietveld 408576698