Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 10409073: Fix harness for fuzzer to run for 100 iterations only. (Closed)

Created:
8 years, 7 months ago by Michael Starzinger
Modified:
8 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix harness for fuzzer to run for 100 iterations only. R=jkummerow@chromium.org TEST=tools/fuzz-harness.sh Committed: https://code.google.com/p/v8/source/detail?r=11629

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Jakob Kummerow. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M tools/fuzz-harness.sh View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
Of course there were local modifications on the Buildbot to the runner as well. This ...
8 years, 7 months ago (2012-05-22 19:15:22 UTC) #1
Jakob Kummerow
Of course. LGTM with comment. https://chromiumcodereview.appspot.com/10409073/diff/1/tools/fuzz-harness.sh File tools/fuzz-harness.sh (right): https://chromiumcodereview.appspot.com/10409073/diff/1/tools/fuzz-harness.sh#newcode68 tools/fuzz-harness.sh:68: cat > "$v8_root/tools/jsfunfuzz.patch" <<- ...
8 years, 7 months ago (2012-05-23 07:49:55 UTC) #2
Michael Starzinger
8 years, 7 months ago (2012-05-23 07:55:59 UTC) #3
Landed.

https://chromiumcodereview.appspot.com/10409073/diff/1/tools/fuzz-harness.sh
File tools/fuzz-harness.sh (right):

https://chromiumcodereview.appspot.com/10409073/diff/1/tools/fuzz-harness.sh#...
tools/fuzz-harness.sh:68: cat > "$v8_root/tools/jsfunfuzz.patch" <<- EOF
On 2012/05/23 07:49:55, Jakob wrote:
> nit: "<< EOF" is sufficient ("<<-" strips leading tabs, which we don't have
> anyway).
> 
> Also, we don't need to persist the .patch file:
> 
> cat << EOF | patch -s -p0 -d "$v8_root"
> [patch contents...]
> EOF

Done.

Powered by Google App Engine
This is Rietveld 408576698