Use browser::ShowWebDialog() directly in MobileSetup rather than using BrowserList.

Use browser::ShowWebDialog() directly in MobileSetup rather than using BrowserList.

http://crbug.com/129187
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138355

[Ben Goodger (Google), 2012-05-22 17:58:30]

http://codereview.chromium.org/10409068/diff/3001/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc (right):

http://codereview.chromium.org/10409068/diff/3001/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc:76:
ProfileManager::GetDefaultProfileOrOffTheRecord(),
Is this how you get the active profile on cros?

[zel, 2012-05-22 18:02:32]

lgtm

http://codereview.chromium.org/10409068/diff/3001/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc (right):

http://codereview.chromium.org/10409068/diff/3001/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc:76:
ProfileManager::GetDefaultProfileOrOffTheRecord(),
On 2012/05/22 17:58:30, Ben Goodger (Google) wrote:
> Is this how you get the active profile on cros?

I think so, even though GetDefaultProfileOrOffTheRecord() method seems new to
me. ProfileManager::GetDefaultProfile() used to give you default or offline
profile depending on login state.

[Ben Goodger (Google), 2012-05-22 18:04:15]

Thanks. sky told me that the "or off the record" variant would return you
an OTR profile as well.

-Ben

On Tue, May 22, 2012 at 11:02 AM, <zelidrag@chromium.org> wrote:

> lgtm
>
>
>
>
>
> http://codereview.chromium.**org/10409068/diff/3001/chrome/**
>
browser/ui/webui/chromeos/**mobile_setup_dialog.cc<http://codereview.chromium.org/10409068/diff/3001/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc>
> File chrome/browser/ui/webui/**chromeos/mobile_setup_dialog.**cc (right):
>
> http://codereview.chromium.**org/10409068/diff/3001/chrome/**
>
browser/ui/webui/chromeos/**mobile_setup_dialog.cc#**newcode76<http://codereview.chromium.org/10409068/diff/3001/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc#newcode76>
> chrome/browser/ui/webui/**chromeos/mobile_setup_dialog.**cc:76:
> ProfileManager::**GetDefaultProfileOrOffTheRecor**d(),
> On 2012/05/22 17:58:30, Ben Goodger (Google) wrote:
>
>> Is this how you get the active profile on cros?
>>
>
> I think so, even though GetDefaultProfileOrOffTheRecor**d() method seems
> new to me. ProfileManager::**GetDefaultProfile() used to give you default
> or offline profile depending on login state.
>
>
http://codereview.chromium.**org/10409068/<http://codereview.chromium.org/104...
>

[Nikita (slow), 2012-05-23 19:01:20]

http://codereview.chromium.org/10409068/diff/3001/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc (right):

http://codereview.chromium.org/10409068/diff/3001/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc:76:
ProfileManager::GetDefaultProfileOrOffTheRecord(),
On 2012/05/22 18:02:32, zel wrote:
> On 2012/05/22 17:58:30, Ben Goodger (Google) wrote:
> > Is this how you get the active profile on cros?
> 
> I think so, even though GetDefaultProfileOrOffTheRecord() method seems new to
> me. ProfileManager::GetDefaultProfile() used to give you default or offline
> profile depending on login state.

This is an ugly hack that we're planning to get rid of:
http://code.google.com/p/chromium/issues/detail?id=128520