Sort by type now sorts by localized string representation of file type.

Sort by type now sorts by localized string representation of file type.

With exception for directories. They come before any file in ascending order.

BUG=126941
TEST=Manual test.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138249

[Vladislav Kaznacheev, 2012-05-22 12:28:45]

https://chromiumcodereview.appspot.com/10409066/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10409066/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:860: return
Number(b.isDirectory) - Number(a.isDirectory);
Nice trick, lets add a comment regarding the intention.

https://chromiumcodereview.appspot.com/10409066/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:865: // Files of
unknown type follows all the others.
The comment does not seem to be relevant anymore (no || 'Z')

[SeRya, 2012-05-22 12:34:35]

https://chromiumcodereview.appspot.com/10409066/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

https://chromiumcodereview.appspot.com/10409066/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:860: return
Number(b.isDirectory) - Number(a.isDirectory);
On 2012/05/22 12:28:45, Vladislav Kaznacheev wrote:
> Nice trick, lets add a comment regarding the intention.

Done.

https://chromiumcodereview.appspot.com/10409066/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/js/file_manager.js:865: // Files of
unknown type follows all the others.
On 2012/05/22 12:28:45, Vladislav Kaznacheev wrote:
> The comment does not seem to be relevant anymore (no || 'Z')

Done.

[Vladislav Kaznacheev, 2012-05-22 13:28:27]

lgtm