dbus/exported_object.cc - Issue 10409065: Change setters of dbus::Message to return false instead of aborting on errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/exported_object.cc

Issue 10409065: Change setters of dbus::Message to return false instead of aborting on errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: _ Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dbus/exported_object.cc

diff --git a/dbus/exported_object.cc b/dbus/exported_object.cc

index 7c4bada3bbcff3c38b796e84ca608df1e224928e..f9ddb62f3f55b4efcd6db6f08563da62ad47a2b1 100644

--- a/dbus/exported_object.cc

+++ b/dbus/exported_object.cc

@@ -90,7 +90,7 @@ void ExportedObject::ExportMethod(const std::string& interface_name,

void ExportedObject::SendSignal(Signal* signal) {

// For signals, the object path should be set to the path to the sender

// object, which is this exported object here.

- signal->SetPath(object_path_);

+ CHECK(signal->SetPath(object_path_));

// Increment the reference count so we can safely reference the

// underlying signal message until the signal sending is complete. This

« no previous file with comments | « dbus/end_to_end_sync_unittest.cc ('k') | dbus/message.h » ('j') | no next file with comments »