Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 10409061: PPAPI/NaCl: Reenable untrusted IPC proxy gyp flag (Closed)

Created:
8 years, 7 months ago by dmichael (off chromium)
Modified:
8 years, 7 months ago
Reviewers:
bbudge, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

PPAPI/NaCl: Reenable untrusted IPC proxy gyp flag The part of chromium that is DEPSed in to WebKit depends on ppapi.gyp via webkit/glue. This puts the conditional include of ppapi_proxy_untrusted.gypi in to a new gyp file creatively named ppapi_proxy_untrusted.gyp. This way we can add it to all.gyp, and we're sure it's not used by WebKit. See also the previous attempt: http://codereview.chromium.org/10399068/ And the partial revert of that: http://codereview.chromium.org/10414010/ BUG=116317 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ppapi/ppapi_proxy_untrusted.gyp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmichael (off chromium)
8 years, 7 months ago (2012-05-21 23:43:17 UTC) #1
bbudge
8 years, 7 months ago (2012-05-22 00:01:06 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698