Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 10409059: Modify gyp files that depend on native_client/build/untrusted.gypi to specialize extra_deps for new… (Closed)

Created:
8 years, 7 months ago by Brad Chen
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Mark Seaborn, bradnelson
Visibility:
Public.

Description

Modify gyp files that depend on native_client/build/untrusted.gypi to specialize extra_deps for newlib and glibc. BUG=127699 TEST=browser_tests (build) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M ppapi/native_client/native_client.gyp View 2 chunks +34 lines, -0 lines 0 comments Download
M ppapi/ppapi_untrusted.gyp View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Brad Chen
8 years, 7 months ago (2012-05-21 22:03:08 UTC) #1
noelallen1
Not sure you needed to do this in two steps instead of just making the ...
8 years, 7 months ago (2012-05-21 22:53:23 UTC) #2
Brad Chen
On 2012/05/21 22:53:23, noelallen1 wrote: > Not sure you needed to do this in two ...
8 years, 7 months ago (2012-05-21 23:18:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradchen@google.com/10409059/1
8 years, 7 months ago (2012-05-21 23:19:41 UTC) #4
commit-bot: I haz the power
Presubmit check for 10409059-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-21 23:19:45 UTC) #5
Brad Chen
Adding dimichael as I need a PPAPI owner.
8 years, 7 months ago (2012-05-21 23:20:56 UTC) #6
dmichael (off chromium)
lgtm
8 years, 7 months ago (2012-05-21 23:48:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradchen@google.com/10409059/1
8 years, 7 months ago (2012-05-22 00:09:10 UTC) #8
commit-bot: I haz the power
Try job failure for 10409059-1 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 7 months ago (2012-05-22 03:36:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradchen@google.com/10409059/1
8 years, 7 months ago (2012-05-22 04:07:59 UTC) #10
commit-bot: I haz the power
Try job failure for 10409059-1 (retry) (retry) (retry) on win_rel for steps "base_unittests, sync_unit_tests" (clobber ...
8 years, 7 months ago (2012-05-22 08:37:14 UTC) #11
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 11:42:30 UTC) #12

Powered by Google App Engine
This is Rietveld 408576698