Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 10409057: Remember user entered passwords for wimax and reshow dialog on bad passphrase. (Closed)

Created:
8 years, 7 months ago by stevenjb
Modified:
8 years, 7 months ago
Reviewers:
zel
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remember user entered passwords for wimax and reshow dialog on bad passphrase. BUG=128429 TEST=Connect to a wimax network with a bad passphrase (anything staring with "bad" in the stub implementation). Dialog should come up again after conenction fails. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138144

Patch Set 1 #

Patch Set 2 : Don't remember user passphrase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M chrome/browser/chromeos/network_login_observer.cc View 2 chunks +24 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stevenjb
Tested the changes from last week and noticed this was missing.
8 years, 7 months ago (2012-05-21 20:42:15 UTC) #1
zel
why would we want to remember passphrase on wimax dialog?
8 years, 7 months ago (2012-05-21 20:59:59 UTC) #2
stevenjb
Just re-show dialog, don't remember password.
8 years, 7 months ago (2012-05-21 21:15:14 UTC) #3
zel
lgtm
8 years, 7 months ago (2012-05-21 21:19:21 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-21 21:20:55 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698