Issue 10409054: Do not show 'No files match "..."' message when GDrive welcome page is shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10409054: Do not show 'No files match "..."' message when GDrive welcome page is shown. (Closed)

Created:
8 years, 7 months ago by Oleg Eterevsky

Modified:
8 years, 7 months ago

Reviewers:
Vladislav Kaznacheev

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Do not show 'No files match "..."' message when GDrive welcome page is shown. BUG=128811 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138106

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	chrome/browser/resources/file_manager/css/file_manager.css	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/file_manager/main.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vladislav Kaznacheev

LGTM with a comment https://chromiumcodereview.appspot.com/10409054/diff/1/chrome/browser/resources/file_manager/css/file_manager.css File chrome/browser/resources/file_manager/css/file_manager.css (right): https://chromiumcodereview.appspot.com/10409054/diff/1/chrome/browser/resources/file_manager/css/file_manager.css#newcode1297 chrome/browser/resources/file_manager/css/file_manager.css:1297: .dialog-container:not([gdrive-welcome='page']) #no-search-results[show='true'] { #no-search-results[show] is ...

8 years, 7 months ago (2012-05-21 17:06:08 UTC) #2

Oleg Eterevsky

8 years, 7 months ago (2012-05-21 17:06:52 UTC) #3

https://chromiumcodereview.appspot.com/10409054/diff/1/chrome/browser/resourc...
File chrome/browser/resources/file_manager/css/file_manager.css (right):

https://chromiumcodereview.appspot.com/10409054/diff/1/chrome/browser/resourc...
chrome/browser/resources/file_manager/css/file_manager.css:1297:
.dialog-container:not([gdrive-welcome='page']) #no-search-results[show='true'] {
On 2012/05/21 17:06:08, Vladislav Kaznacheev wrote:
> #no-search-results[show] is enough

Done.

Expand Messages | Collapse Messages

Issue 10409054: Do not show 'No files match "..."' message when GDrive welcome page is shown. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages