Issue 10409031: Fix crash when download from popup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10409031: Fix crash when download from popup. (Closed)

Created:
8 years, 7 months ago by Avi (use Gerrit)

Modified:
8 years, 7 months ago

Reviewers:
Randy Smith (Not in Mondays)

CC:
chromium-reviews, rdsmith+dwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash when download from popup. BUG=128368 TEST=as in bug

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -22 lines)			Patch
M	chrome/browser/download/download_request_limiter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_request_limiter.cc	View	3 chunks	+27 lines, -20 lines	0 comments	Download
M	chrome/browser/download/download_request_limiter_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

Harder than this looks. Try clicking a _second_ time, and the request limiter wants to ...

8 years, 7 months ago (2012-05-18 17:00:35 UTC) #1

Randy Smith (Not in Mondays)

Not sure if you're looking for a review from me, but this LGTM from a ...

8 years, 7 months ago (2012-05-18 17:34:22 UTC) #2

Avi (use Gerrit)

8 years, 7 months ago (2012-05-18 17:37:58 UTC) #3

On 2012/05/18 17:34:22, rdsmith wrote:
> Not sure if you're looking for a review from me, but this LGTM from a code
point
> of view.  Does attempting to infobar the bubble cause another crash?

Yes, which is why I'm not landing this. I wanted to pass this patch on to
whoever tackled bug 128368. The question then is: should we be rate-limiting
downloads from extensions?

BTW, the download doesn't cause the download shelf to appear. Perhaps that's
another bug.

Expand Messages | Collapse Messages