Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 10409029: Add a factory function to create WebContentsView implementations. (Closed)

Created:
8 years, 7 months ago by jam
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Add a factory function to create WebContentsView implementations. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137876

Patch Set 1 #

Patch Set 2 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -44 lines) Patch
M content/browser/web_contents/web_contents_impl.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +2 lines, -22 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 2 chunks +0 lines, -18 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_view_win.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 7 months ago (2012-05-18 16:07:29 UTC) #1
Ben Goodger (Google)
8 years, 7 months ago (2012-05-18 16:08:30 UTC) #2
Nice! LGTM

Powered by Google App Engine
This is Rietveld 408576698