Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: chrome/browser/logging_chrome_browsertest.cc

Issue 10409026: Mark RendererCrashTest.Crash as flaky (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/environment.h" 6 #include "base/environment.h"
7 #include "chrome/common/chrome_switches.h" 7 #include "chrome/common/chrome_switches.h"
8 #include "chrome/common/url_constants.h" 8 #include "chrome/common/url_constants.h"
9 #include "chrome/common/env_vars.h" 9 #include "chrome/common/env_vars.h"
10 #include "chrome/common/logging_chrome.h" 10 #include "chrome/common/logging_chrome.h"
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION) { 82 status == base::TERMINATION_STATUS_ABNORMAL_TERMINATION) {
83 saw_crash_ = true; 83 saw_crash_ = true;
84 } 84 }
85 MessageLoopForUI::current()->Quit(); 85 MessageLoopForUI::current()->Quit();
86 } 86 }
87 87
88 bool saw_crash_; 88 bool saw_crash_;
89 content::NotificationRegistrar registrar_; 89 content::NotificationRegistrar registrar_;
90 }; 90 };
91 91
92 IN_PROC_BROWSER_TEST_F(RendererCrashTest, Crash) { 92 IN_PROC_BROWSER_TEST_F(RendererCrashTest, FLAKY_Crash) {
93 registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_CLOSED, 93 registrar_.Add(this, content::NOTIFICATION_RENDERER_PROCESS_CLOSED,
94 content::NotificationService::AllSources()); 94 content::NotificationService::AllSources());
95 ui_test_utils::NavigateToURLWithDisposition( 95 ui_test_utils::NavigateToURLWithDisposition(
96 browser(), GURL(chrome::kChromeUICrashURL), CURRENT_TAB, 0); 96 browser(), GURL(chrome::kChromeUICrashURL), CURRENT_TAB, 0);
97 ui_test_utils::RunMessageLoop(); 97 ui_test_utils::RunMessageLoop();
98 ASSERT_TRUE(saw_crash_); 98 ASSERT_TRUE(saw_crash_);
99 } 99 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698