Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Side by Side Diff: chrome/browser/ui/webui/help/version_updater_chromeos.h

Issue 10409025: Use WeakPtr in VersionUpdaterCros for safety (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/webui/help/version_updater_chromeos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_HELP_VERSION_UPDATER_CHROMEOS_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_HELP_VERSION_UPDATER_CHROMEOS_H_
6 #define CHROME_BROWSER_UI_WEBUI_HELP_VERSION_UPDATER_CHROMEOS_H_ 6 #define CHROME_BROWSER_UI_WEBUI_HELP_VERSION_UPDATER_CHROMEOS_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/weak_ptr.h"
10 #include "chrome/browser/ui/webui/help/version_updater.h" 11 #include "chrome/browser/ui/webui/help/version_updater.h"
11 #include "chromeos/dbus/update_engine_client.h" 12 #include "chromeos/dbus/update_engine_client.h"
12 13
13 class VersionUpdaterCros : public VersionUpdater, 14 class VersionUpdaterCros : public VersionUpdater,
14 public chromeos::UpdateEngineClient::Observer { 15 public chromeos::UpdateEngineClient::Observer {
15 public: 16 public:
16 // VersionUpdater implementation. 17 // VersionUpdater implementation.
17 virtual void CheckForUpdate(const StatusCallback& callback) OVERRIDE; 18 virtual void CheckForUpdate(const StatusCallback& callback) OVERRIDE;
18 virtual void RelaunchBrowser() const OVERRIDE; 19 virtual void RelaunchBrowser() const OVERRIDE;
19 virtual void SetReleaseChannel(const std::string& channel) OVERRIDE; 20 virtual void SetReleaseChannel(const std::string& channel) OVERRIDE;
(...skipping 16 matching lines...) Expand all
36 37
37 // Callback from UpdateEngineClient::GetReleaseTrack(). 38 // Callback from UpdateEngineClient::GetReleaseTrack().
38 void UpdateSelectedChannel(const std::string& channel); 39 void UpdateSelectedChannel(const std::string& channel);
39 40
40 // Callback used to communicate update status to the client. 41 // Callback used to communicate update status to the client.
41 StatusCallback callback_; 42 StatusCallback callback_;
42 43
43 // Callback used to communicate current channel to the client. 44 // Callback used to communicate current channel to the client.
44 ChannelCallback channel_callback_; 45 ChannelCallback channel_callback_;
45 46
47 base::WeakPtrFactory<VersionUpdaterCros> weak_ptr_factory_;
48
46 DISALLOW_COPY_AND_ASSIGN(VersionUpdaterCros); 49 DISALLOW_COPY_AND_ASSIGN(VersionUpdaterCros);
47 }; 50 };
48 51
49 #endif // CHROME_BROWSER_UI_WEBUI_HELP_VERSION_UPDATER_CHROMEOS_H_ 52 #endif // CHROME_BROWSER_UI_WEBUI_HELP_VERSION_UPDATER_CHROMEOS_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/webui/help/version_updater_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698