Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10409023: Remove extension application launch code from Browser (Closed)

Created:
8 years, 7 months ago by benwells
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, stevenjb
Visibility:
Public.

Description

Remove extension application launch code from Browser This doesn't need to be in Browser, and won't always open a Browser window. BUG=None TEST=Existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138448

Patch Set 1 #

Patch Set 2 : Browser stuff removed; compiles #

Total comments: 4

Patch Set 3 : Namespace fixed #

Patch Set 4 : Rebase #

Patch Set 5 : Renamed namespace #

Patch Set 6 : Fix ash #

Patch Set 7 : More ash #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -379 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/app_notification_browsertest.cc View 1 2 3 4 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 5 6 7 5 chunks +14 lines, -61 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 6 7 3 chunks +0 lines, -282 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 2 3 4 5 6 7 2 chunks +6 lines, -5 lines 0 comments Download
A chrome/browser/ui/extensions/application_launch.h View 1 2 3 4 5 1 chunk +76 lines, -0 lines 0 comments Download
A chrome/browser/ui/extensions/application_launch.cc View 1 2 3 4 5 6 7 1 chunk +325 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_app_browsertest.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_impl.cc View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/ash/extension_utils.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
benwells
Experimental WIP. Obviously need to clean up browser.h / browser.cc and make callers use the ...
8 years, 7 months ago (2012-05-18 06:51:09 UTC) #1
benwells
No longer WIP. Still let me know if this is a bad idea for some ...
8 years, 7 months ago (2012-05-18 13:21:51 UTC) #2
sky
Excellent cleanup. Just fix the namespace and LGTM http://codereview.chromium.org/10409023/diff/3001/chrome/browser/ui/browser.h File chrome/browser/ui/browser.h (right): http://codereview.chromium.org/10409023/diff/3001/chrome/browser/ui/browser.h#newcode821 chrome/browser/ui/browser.h:821: pending_web_app_action_ ...
8 years, 7 months ago (2012-05-18 16:04:02 UTC) #3
benwells
+aa who may have something to day about this going to extensions directory and namespace ...
8 years, 7 months ago (2012-05-21 03:25:54 UTC) #4
benwells
Changed namespace to application_launch after discussing with aa@. Gonna commit now...
8 years, 7 months ago (2012-05-22 02:03:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10409023/2006
8 years, 7 months ago (2012-05-22 02:03:51 UTC) #6
commit-bot: I haz the power
Try job failure for 10409023-2006 (retry) (retry) on win_rel for steps "base_unittests, sync_unit_tests". It's a ...
8 years, 7 months ago (2012-05-22 06:19:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10409023/2006
8 years, 7 months ago (2012-05-22 06:57:35 UTC) #8
commit-bot: I haz the power
Try job failure for 10409023-2006 (retry) (retry) on win_rel for steps "base_unittests, sync_unit_tests" (clobber build). ...
8 years, 7 months ago (2012-05-22 12:00:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10409023/2006
8 years, 7 months ago (2012-05-22 21:25:35 UTC) #10
commit-bot: I haz the power
Try job failure for 10409023-2006 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 21:50:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10409023/6025
8 years, 7 months ago (2012-05-23 00:41:36 UTC) #12
commit-bot: I haz the power
Try job failure for 10409023-6025 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-23 03:36:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10409023/6025
8 years, 7 months ago (2012-05-23 04:09:55 UTC) #14
commit-bot: I haz the power
Try job failure for 10409023-6025 (retry) on win_rel for step "runhooks" (clobber build). It's a ...
8 years, 7 months ago (2012-05-23 06:01:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10409023/6025
8 years, 7 months ago (2012-05-23 06:02:56 UTC) #16
Mihai Parparita -not on Chrome
The win_rel tryservers have been flaky all day (see https://groups.google.com/a/chromium.org/group/chromium-dev/browse_frm/thread/7332c140085d28de#), you may want to just ...
8 years, 7 months ago (2012-05-23 06:05:25 UTC) #17
commit-bot: I haz the power
List of reviewers changed. mihaip@chromium.org did a drive-by without LGTM'ing!
8 years, 7 months ago (2012-05-23 07:41:47 UTC) #18
benwells
8 years, 7 months ago (2012-05-23 07:58:24 UTC) #19 
On 2012/05/23 06:05:25, Mihai Parparita wrote:
> The win_rel tryservers have been flaky all day (see
>
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_frm/thread...),
> you may want to just dcommit.
> 
> Mihai
> 
> On Tue, May 22, 2012 at 11:02 PM, <mailto:commit-bot@chromium.org> wrote:
> 
> > CQ is trying da patch. Follow status at
> > https://chromium-status.**appspot.com/cq/benwells%40**
> >
>
chromium.org/10409023/6025<https://chromium-status.appspot.com/cq/benwells@chromium.org/10409023/6025>
> >
> >
> >
>
https://chromiumcodereview.**appspot.com/10409023/%3Chttps://chromiumcoderevi...>
> >

Will do now.

Powered by Google App Engine
This is Rietveld 408576698