Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10409022: Move application lifetime functionality off BrowserList. (Closed)

Created:
8 years, 7 months ago by Ben Goodger (Google)
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, ncarter (slow), mihaip-chromium-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, Raghu Simha, kkania, Aaron Boodman, robertshield, davemoore+watch_chromium.org, stevenjb+watch_chromium.org, tim (not reviewing), akalin
Visibility:
Public.

Description

Move application lifetime functionality off BrowserList. This makes no attempt to really rationalize/simplify this flow, just get it off the BrowserList. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137927

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -1234 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/background/background_mode_manager_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_ash.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main_posix.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/power_button_controller_delegate_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/lifetime/application_lifetime.h View 1 chunk +59 lines, -221 lines 0 comments Download
A + chrome/browser/lifetime/application_lifetime.cc View 17 chunks +42 lines, -377 lines 0 comments Download
A + chrome/browser/lifetime/application_lifetime_aura.cc View 2 chunks +8 lines, -5 lines 0 comments Download
A + chrome/browser/lifetime/application_lifetime_gtk.cc View 2 chunks +6 lines, -3 lines 0 comments Download
A + chrome/browser/lifetime/application_lifetime_mac.mm View 1 chunk +6 lines, -3 lines 0 comments Download
A + chrome/browser/lifetime/application_lifetime_stub.cc View 1 chunk +6 lines, -3 lines 0 comments Download
A + chrome/browser/lifetime/application_lifetime_win.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_list.h View 2 chunks +0 lines, -77 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 9 chunks +15 lines, -350 lines 0 comments Download
D chrome/browser/ui/browser_list_aura.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/ui/browser_list_gtk.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/browser_list_mac.mm View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/ui/browser_list_stub.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/browser_list_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
D chrome/browser/ui/browser_list_win.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/restart_browser.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/update_recommended_dialog.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/about_chrome_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/critical_notification_bubble_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/update_recommended_message_box.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_mac.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/language_options_handler2.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/upgrade_detector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 8 chunks +13 lines, -11 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
8 years, 7 months ago (2012-05-18 17:38:36 UTC) #1
Ben Goodger (Google)
I have not really tried to refactor/improve any of the shutdown flows, even though they ...
8 years, 7 months ago (2012-05-18 17:39:02 UTC) #2
sky
8 years, 7 months ago (2012-05-18 17:41:05 UTC) #3 
LGTM

Powered by Google App Engine
This is Rietveld 408576698